From: Jakub Kicinski <kuba@kernel.org>
To: Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] RDMA/rxe: Fetch skb packets from ethernet layer
Date: Mon, 9 Nov 2020 10:25:18 -0800 [thread overview]
Message-ID: <20201109102518.6b3d92a5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAD=hENdP8sJrBZ7uDEWtatZ3D6bKQY=wBKdM5NQ79xveohAnhQ@mail.gmail.com>
On Sun, 8 Nov 2020 13:27:32 +0800 Zhu Yanjun wrote:
> On Sun, Nov 8, 2020 at 1:24 PM Zhu Yanjun <zyjzyj2000@gmail.com> wrote:
> > On Thu, 5 Nov 2020 19:12:01 +0800 Zhu Yanjun wrote:
> >
> > In the original design, in rx, skb packet would pass ethernet
> > layer and IP layer, eventually reach udp tunnel.
> >
> > Now rxe fetches the skb packets from the ethernet layer directly.
> > So this bypasses the IP and UDP layer. As such, the skb packets
> > are sent to the upper protocals directly from the ethernet layer.
> >
> > This increases bandwidth and decreases latency.
> >
> > Signed-off-by: Zhu Yanjun <yanjunz@nvidia.com>
> >
> >
> > Nope, no stealing UDP packets with some random rx handlers.
>
> Why? Is there any risks?
Are there risks in layering violations? Yes.
For example - you do absolutely no protocol parsing, checksum
validation, only support IPv4, etc.
Besides it also makes the code far less maintainable, rx_handler is a
singleton, etc. etc.
> > The tunnel socket is a correct approach.
next prev parent reply other threads:[~2020-11-09 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 11:12 [PATCH 1/1] RDMA/rxe: Fetch skb packets from ethernet layer Zhu Yanjun
2020-11-07 20:26 ` Jakub Kicinski
[not found] ` <222b9c1b-9d60-22f3-6097-8abd651cc192@gmail.com>
2020-11-08 5:27 ` Zhu Yanjun
2020-11-09 18:25 ` Jakub Kicinski [this message]
2020-11-10 1:58 ` Zhu Yanjun
2020-11-11 11:15 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109102518.6b3d92a5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).