From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E98C2D0A3 for ; Mon, 9 Nov 2020 22:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 817BD2074F for ; Mon, 9 Nov 2020 22:17:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="KcFPTBvE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730024AbgKIWRA (ORCPT ); Mon, 9 Nov 2020 17:17:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:53530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729336AbgKIWRA (ORCPT ); Mon, 9 Nov 2020 17:17:00 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16EB9206BE; Mon, 9 Nov 2020 22:16:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604960219; bh=ROrsqtYaKXfk3QoJVLVQQdpZkH8gX3j3DtkJ5PIVV2g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KcFPTBvE4LyxKT+LnRnmg0jcIbffymp9YQmfgjOZC3m/0SUcWvVAARlRURhXfNw95 49109i5GvRP7Lv9n68YxB7xWfcNHmLrXBtZfhIAA42MdvEPDOc20fSwIAotRs4Fcm/ NmoQtEjS0fTNI44pXBpCdjMqrckZryZ5g2P839MM= Date: Mon, 9 Nov 2020 14:16:58 -0800 From: Jakub Kicinski To: "Georg Kohmann (geokohma)" Cc: "netdev@vger.kernel.org" , "pablo@netfilter.org" , "kadlec@netfilter.org" , "fw@strlen.de" , "davem@davemloft.net" , "kuznet@ms2.inr.ac.ru" , "yoshfuji@linux-ipv6.org" , "netfilter-devel@vger.kernel.org" , "coreteam@netfilter.org" Subject: Re: [PATCH net v3] ipv6/netfilter: Discard first fragment not including all headers Message-ID: <20201109141658.0265373d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <3c81d2ae-ba14-60d8-247d-87fabf407fea@cisco.com> References: <20201109115249.14491-1-geokohma@cisco.com> <20201109125009.5e54ec8b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <3c81d2ae-ba14-60d8-247d-87fabf407fea@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 9 Nov 2020 22:08:47 +0000 Georg Kohmann (geokohma) wrote: > >> +bool ipv6_frag_validate(struct sk_buff *skb, int start, u8 *nexthdrp) > > (a) why place this function in exthdrs_core? I don't see any header > > specific code here, IMO it belongs in reassembly.c. > > ipv6_frag_validate() is used in both reassembly.c and nf_conntrack_reasm.c > Where should I put the prototype so it can be used both places? The prototype can stay in net/ipv6.h