From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0531CC388F7 for ; Mon, 9 Nov 2020 14:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFCE32083B for ; Mon, 9 Nov 2020 14:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730836AbgKIOrH (ORCPT ); Mon, 9 Nov 2020 09:47:07 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:43154 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730338AbgKIOrG (ORCPT ); Mon, 9 Nov 2020 09:47:06 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kc8Rd-0066BU-T1; Mon, 09 Nov 2020 15:46:57 +0100 Date: Mon, 9 Nov 2020 15:46:57 +0100 From: Andrew Lunn To: zhangxiaoxu Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: dsa: mv88e6xxx: Fix memleak in mv88e6xxx_region_atu_snapshot Message-ID: <20201109144657.GH1258576@lunn.ch> References: <20201109144416.1540867-1-zhangxiaoxu5@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109144416.1540867-1-zhangxiaoxu5@huawei.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Nov 09, 2020 at 09:44:16AM -0500, zhangxiaoxu wrote: > When mv88e6xxx_fid_map return error, we lost free the table. > > Fix it. > > Fixes: bfb255428966 ("net: dsa: mv88e6xxx: Add devlink regions") > Reported-by: Hulk Robot > Signed-off-by: zhangxiaoxu Reviewed-by: Andrew Lunn Andrew