From: Jakub Kicinski <kuba@kernel.org>
To: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, borisp@nvidia.com,
secdev@chelsio.com
Subject: Re: [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP
Date: Tue, 10 Nov 2020 08:28:32 -0800 [thread overview]
Message-ID: <20201110082832.4ef61eff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <0cd430df-167a-be86-66c5-f0838ed24641@chelsio.com>
On Tue, 10 Nov 2020 10:37:11 +0530 Vinay Kumar Yadav wrote:
> It is not incompatible. It fits in k.org tls infrastructure (TLS-TOE
> mode). For the current issue we have proposed a fix. What is the issue
> with proposed fix, can you elaborate and we will address that?
Your lack of understanding of how netdev offloads are supposed to work
is concerning. Application is not supposed to see any difference
between offloaded and non-offloaded modes of operation.
Your offload was accepted based on the assumption that it works like
the software kernel TLS mode. Nobody had the time to look at your
thousands lines of driver code at the time.
Now you're telling us that the uAPI for the offload is completely
different - it only works on listening sockets while software tls
only works on established sockets. Ergo there is no software fallback
for your offload.
Furthermore the severity of the bugs you just started to fix now, after
the code has been in the kernel for over a year suggests there are no
serious users and we can just remove this code.
next prev parent reply other threads:[~2020-11-10 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 10:47 [PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP Vinay Kumar Yadav
2020-11-05 1:16 ` Jakub Kicinski
2020-11-05 17:50 ` Vinay Kumar Yadav
2020-11-05 17:53 ` Jakub Kicinski
2020-11-05 18:25 ` Vinay Kumar Yadav
2020-11-05 18:46 ` Jakub Kicinski
2020-11-06 20:32 ` Vinay Kumar Yadav
2020-11-06 20:28 ` Jakub Kicinski
2020-11-09 18:51 ` Vinay Kumar Yadav
2020-11-09 18:58 ` Jakub Kicinski
2020-11-10 5:07 ` Vinay Kumar Yadav
2020-11-10 5:58 ` Vinay Kumar Yadav
2020-11-10 16:28 ` Jakub Kicinski [this message]
2020-11-10 19:49 ` Vinay Kumar Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110082832.4ef61eff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=secdev@chelsio.com \
--cc=vinay.yadav@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).