From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Mao Wenan <wenan.mao@linux.alibaba.com>,
David Miller <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net v5] net: Update window_clamp if SOCK_RCVBUF is set
Date: Tue, 10 Nov 2020 17:45:01 -0800 [thread overview]
Message-ID: <20201110174501.703879e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CANn89iL6UW9mG6hW7f3Yv+32Pe_i9F-5cQhfo2uV68wdcgSuZA@mail.gmail.com>
On Tue, 10 Nov 2020 08:32:52 +0100 Eric Dumazet wrote:
> On Tue, Nov 10, 2020 at 1:16 AM Mao Wenan <wenan.mao@linux.alibaba.com> wrote:
> > When net.ipv4.tcp_syncookies=1 and syn flood is happened,
> > cookie_v4_check or cookie_v6_check tries to redo what
> > tcp_v4_send_synack or tcp_v6_send_synack did,
> > rsk_window_clamp will be changed if SOCK_RCVBUF is set,
> > which will make rcv_wscale is different, the client
> > still operates with initial window scale and can overshot
> > granted window, the client use the initial scale but local
> > server use new scale to advertise window value, and session
> > work abnormally.
> >
> > Fixes: e88c64f0a425 ("tcp: allow effective reduction of TCP's rcv-buffer via setsockopt")
> > Signed-off-by: Mao Wenan <wenan.mao@linux.alibaba.com>
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks!
prev parent reply other threads:[~2020-11-11 1:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:20 [PATCH] net: Update window_clamp if SOCK_RCVBUF is set Mao Wenan
2020-11-09 9:33 ` [PATCH net v2] " Mao Wenan
2020-11-09 9:56 ` Eric Dumazet
2020-11-09 10:12 ` Mao Wenan
2020-11-09 10:19 ` Mao Wenan
2020-11-09 11:02 ` Eric Dumazet
2020-11-09 11:41 ` Eric Dumazet
2020-11-09 14:01 ` Eric Dumazet
2020-11-09 16:26 ` Mao Wenan
2020-11-09 16:53 ` [PATCH net v3] " Mao Wenan
2020-11-09 16:59 ` Eric Dumazet
2020-11-09 17:17 ` [PATCH net v4] " Mao Wenan
2020-11-09 17:28 ` Eric Dumazet
2020-11-10 0:16 ` [PATCH net v5] " Mao Wenan
2020-11-10 7:32 ` Eric Dumazet
2020-11-11 1:45 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110174501.703879e8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wenan.mao@linux.alibaba.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).