From: Jakub Kicinski <kuba@kernel.org>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: netdev@vger.kernel.org, Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net-next] net: phy: aquantia: do not return an error on clearing pending IRQs
Date: Wed, 11 Nov 2020 14:11:25 -0800 [thread overview]
Message-ID: <20201111141125.67c62e95@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201109154601.3812574-1-ciorneiioana@gmail.com>
On Mon, 9 Nov 2020 17:46:01 +0200 Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@nxp.com>
>
> The referenced commit added in .config_intr() the part of code which upon
> configuration of the IRQ state it also clears up any pending IRQ. If
> there were actually pending IRQs, a read on the IRQ status register will
> return something non zero. This should not result in the callback
> returning an error.
>
> Fix this by returning an error only when the result of the
> phy_read_mmd() is negative.
>
> Fixes: e11ef96d44f1 ("net: phy: aquantia: remove the use of .ack_interrupt()")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Applied, thanks!
prev parent reply other threads:[~2020-11-11 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 15:46 [PATCH net-next] net: phy: aquantia: do not return an error on clearing pending IRQs Ioana Ciornei
2020-11-11 16:44 ` Camelia Alexandra Groza
2020-11-11 22:11 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111141125.67c62e95@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=ciorneiioana@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).