From: Jakub Kicinski <kuba@kernel.org>
To: Karsten Graul <kgraul@linux.ibm.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, hca@linux.ibm.com,
raspl@linux.ibm.com
Subject: Re: [PATCH net-next v4 09/15] net/smc: Introduce SMCR get linkgroup command
Date: Fri, 13 Nov 2020 08:45:57 -0800 [thread overview]
Message-ID: <20201113084557.4905813d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <3be40d64-3952-3de9-559b-2ee55449b54c@linux.ibm.com>
On Fri, 13 Nov 2020 16:08:39 +0100 Karsten Graul wrote:
> On 11/11/2020 23:34, Jakub Kicinski wrote:
> > On Mon, 9 Nov 2020 16:18:08 +0100 Karsten Graul wrote:
> >> @@ -295,6 +377,14 @@ static int smc_diag_dump(struct sk_buff *skb, struct netlink_callback *cb)
> >>
> >> static int smc_diag_dump_ext(struct sk_buff *skb, struct netlink_callback *cb)
> >> {
> >> + struct smc_diag_req_v2 *req = nlmsg_data(cb->nlh);
> >> +
> >> + if (req->cmd == SMC_DIAG_GET_LGR_INFO) {
> >> + if ((req->cmd_ext & (1 << (SMC_DIAG_LGR_INFO_SMCR - 1))))
> >> + smc_diag_fill_lgr_list(smc_diag_ops->get_lgr_list(),
> >> + skb, cb, req);
> >> + }
> >> +
> >> return skb->len;
> >> }
> >
> > IDK if this is appropriate for socket diag handler.
> >
> > Is there precedent for funneling commands through socket diag instead
> > of just creating a genetlink family?
>
> Thank you for your valuable comments. We are looking into a better way
> to retrieve the various information from the kernel into user space,
> and we will come up with a v5 for that.
Thanks, but do double check that no other socket type is doing this,
I'm far from a socket layer expert.
next prev parent reply other threads:[~2020-11-13 16:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 15:17 [PATCH net-next v4 00/15] net/smc: extend diagnostic netlink interface Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 01/15] net/smc: use helper smc_conn_abort() in listen processing Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 02/15] net/smc: Use active link of the connection Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 03/15] net/smc: Add connection counters for links Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 04/15] net/smc: Add link counters for IB device ports Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 05/15] net/smc: Add diagnostic information to smc ib-device Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 06/15] net/smc: Add diagnostic information to link structure Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 07/15] net/smc: Refactor the netlink reply processing routine Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 08/15] net/smc: Add ability to work with extended SMC netlink API Karsten Graul
2020-11-11 22:25 ` Jakub Kicinski
2020-11-09 15:18 ` [PATCH net-next v4 09/15] net/smc: Introduce SMCR get linkgroup command Karsten Graul
2020-11-11 22:34 ` Jakub Kicinski
2020-11-13 15:08 ` Karsten Graul
2020-11-13 16:45 ` Jakub Kicinski [this message]
2020-11-09 15:18 ` [PATCH net-next v4 10/15] net/smc: Introduce SMCR get link command Karsten Graul
2020-11-11 22:34 ` Jakub Kicinski
2020-11-09 15:18 ` [PATCH net-next v4 11/15] net/smc: Add SMC-D Linkgroup diagnostic support Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 12/15] net/smc: Add support for obtaining SMCD device list Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 13/15] net/smc: Add support for obtaining SMCR " Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 14/15] net/smc: Refactor smc ism v2 capability handling Karsten Graul
2020-11-09 15:18 ` [PATCH net-next v4 15/15] net/smc: Add support for obtaining system information Karsten Graul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113084557.4905813d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=hca@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).