From: Andrew Lunn <andrew@lunn.ch>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Jernej Škrabec" <jernej.skrabec@gmail.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Sumit Garg" <sumit.garg@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Steve McIntyre" <steve@einval.com>,
"open list:BPF JIT for MIPS (32-BIT AND 64-BIT)"
<netdev@vger.kernel.org>, "Willy Liu" <willy.liu@realtek.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Sasha Levin" <sashal@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Masahisa Kojima" <masahisa.kojima@linaro.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>
Subject: Re: Re: realtek PHY commit bbc4d71d63549 causes regression
Date: Fri, 13 Nov 2020 15:44:01 +0100 [thread overview]
Message-ID: <20201113144401.GM1456319@lunn.ch> (raw)
In-Reply-To: <CAK8P3a2hBpQAsRekNyauUF1MgdO8CON=77MNSd0E-U1TWNT-gA@mail.gmail.com>
> > Sadly, there is one board - Pine64 Plus - where HW settings are wrong and it
> > actually needs SW override. Until this Realtek PHY driver fix was merged, it
> > was unclear what magic value provided by Realtek to board manufacturer does.
> >
> > Reference:
> > https://lore.kernel.org/netdev/20191001082912.12905-3-icenowy@aosc.io/
>
> I have merged the fixes from the allwinner tree now, but I still think we
> need something better than this, as the current state breaks any existing
> dtb file that has the incorrect values, and this really should not have been
> considered for backporting to stable kernels.
Hi Arnd
This PHY driver bug hiding DT bug is always hard to handle. We have
been though it once before with the Atheros PHY. All the buggy DT
files were fixed in about one cycle.
Now that we know there is a board which really does want rgmii when it
says rgmii, we cannot simply ignore it in the PHY driver.
But the whole story is muddy because of the backport to stable. It
might make sense to revert the stable change, and just leave HEAD
broken. That then gives people more time to fix DT blobs. But we have
to consider Pine64 Plus, are we happy breaking that for a while, when
it is actually doing everything correct, and is bug free?
Andrew
next prev parent reply other threads:[~2020-11-13 14:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 14:20 realtek PHY commit bbc4d71d63549 causes regression Ard Biesheuvel
2020-10-17 14:44 ` Andrew Lunn
2020-10-17 14:46 ` Ard Biesheuvel
2020-10-17 15:11 ` Andrew Lunn
2020-10-17 15:18 ` Ard Biesheuvel
2020-10-17 16:14 ` Ilias Apalodimas
2020-10-17 16:17 ` Ard Biesheuvel
2020-10-17 16:21 ` Ilias Apalodimas
2020-10-17 18:04 ` Andrew Lunn
2020-10-17 18:11 ` Ard Biesheuvel
2020-10-17 18:17 ` Ard Biesheuvel
2020-10-17 18:27 ` Andrew Lunn
2020-10-17 18:55 ` Ard Biesheuvel
2020-10-17 19:49 ` Andrew Lunn
2020-10-17 22:19 ` Ard Biesheuvel
2020-10-17 23:02 ` Andrew Lunn
2020-10-18 10:35 ` Ard Biesheuvel
2020-10-18 10:56 ` Ard Biesheuvel
2020-10-18 15:45 ` Andrew Lunn
2020-10-25 14:16 ` Ard Biesheuvel
2020-10-25 14:28 ` Andrew Lunn
2020-10-25 14:34 ` Ard Biesheuvel
2020-10-25 14:42 ` Andrew Lunn
2020-10-29 14:21 ` Ilias Apalodimas
2020-10-29 14:39 ` Andrew Lunn
2020-10-29 14:42 ` Ard Biesheuvel
2020-10-29 14:50 ` Andrew Lunn
2020-10-29 14:46 ` Ilias Apalodimas
2020-11-05 17:31 ` Jernej Škrabec
2020-11-13 13:50 ` Arnd Bergmann
2020-11-13 14:44 ` Andrew Lunn [this message]
2020-11-13 15:33 ` Arnd Bergmann
2020-11-13 16:56 ` Andrew Lunn
2020-11-13 21:26 ` Arnd Bergmann
2020-11-13 22:43 ` Andrew Lunn
2020-11-13 22:49 ` Ard Biesheuvel
2020-11-14 0:40 ` Andrew Lunn
2020-11-14 10:09 ` Ard Biesheuvel
2020-10-18 15:38 ` Andrew Lunn
2020-10-18 14:20 ` Masami Hiramatsu
2020-10-17 18:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113144401.GM1456319@lunn.ch \
--to=andrew@lunn.ch \
--cc=alex.bennee@linaro.org \
--cc=ardb@kernel.org \
--cc=arnd@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jernej.skrabec@gmail.com \
--cc=kuba@kernel.org \
--cc=masahisa.kojima@linaro.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=steve@einval.com \
--cc=sumit.garg@linaro.org \
--cc=willy.liu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).