From: Jakub Kicinski <kuba@kernel.org>
To: Andrea Mayer <andrea.mayer@uniroma2.it>
Cc: David Ahern <dsahern@gmail.com>,
Stefano Salsano <stefano.salsano@uniroma2.it>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Shuah Khan <shuah@kernel.org>,
Shrijeet Mukherjee <shrijeet@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Paolo Lungaroni <paolo.lungaroni@cnit.it>,
Ahmed Abdelsalam <ahabdels.dev@gmail.com>
Subject: Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior
Date: Fri, 13 Nov 2020 15:54:37 -0800 [thread overview]
Message-ID: <20201113155437.7d82550b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201114000024.614c6c097050188abc87a7ff@uniroma2.it>
On Sat, 14 Nov 2020 00:00:24 +0100 Andrea Mayer wrote:
> On Fri, 13 Nov 2020 13:40:10 -0800
> Jakub Kicinski <kuba@kernel.org> wrote:
>
> > On Fri, 13 Nov 2020 11:40:36 -0800 Jakub Kicinski wrote:
> > > > agreed. The v6 variant has existed for a while. The v4 version is
> > > > independent.
> > >
> > > Okay, I'm not sure what's the right call so I asked DaveM.
> >
> > DaveM raised a concern that unless we implement v6 now we can't be sure
> > the interface we create for v4 is going to fit there.
> >
> > So Andrea unless it's a major hurdle, could you take a stab at the v6
> > version with VRFs as part of this series?
>
> I can tackle the v6 version but how do we face the compatibility issue raised
> by Stefano in his message?
>
> if it is ok to implement a uAPI that breaks the existing scripts, it is relatively
> easy to replicate the VRF-based approach also in v6.
We need to keep existing End.DT6 as is, and add a separate
implementation.
The way to distinguish between the two could be either by passing via
netlink a flag attribute (which would request use of VRF in both
cases); using a different attribute than SEG6_LOCAL_TABLE for the
table id (or perhaps passing VRF's ifindex instead), e.g.
SEG6_LOCAL_TABLE_VRF; or adding a new command
(SEG6_LOCAL_ACTION_END_DT6_VRF) which would behave like End.DT4.
next prev parent reply other threads:[~2020-11-13 23:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 15:31 [net-next,v2,0/5] seg6: add support for SRv6 End.DT4 behavior Andrea Mayer
2020-11-07 15:31 ` [net-next,v2,1/5] vrf: add mac header for tunneled packets when sniffer is attached Andrea Mayer
2020-11-10 22:50 ` Jakub Kicinski
2020-11-13 0:37 ` Andrea Mayer
2020-11-07 15:31 ` [net-next,v2,2/5] seg6: improve management of behavior attributes Andrea Mayer
2020-11-10 22:50 ` Jakub Kicinski
2020-11-13 0:55 ` Andrea Mayer
2020-11-07 15:31 ` [net-next,v2,3/5] seg6: add callbacks for customizing the creation/destruction of a behavior Andrea Mayer
2020-11-10 22:56 ` Jakub Kicinski
2020-11-13 1:06 ` Andrea Mayer
2020-11-07 15:31 ` [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior Andrea Mayer
2020-11-10 23:12 ` Jakub Kicinski
2020-11-13 1:28 ` Andrea Mayer
2020-11-13 1:49 ` David Ahern
2020-11-13 16:55 ` Jakub Kicinski
2020-11-13 17:02 ` Stefano Salsano
2020-11-13 17:04 ` David Ahern
2020-11-13 19:40 ` Jakub Kicinski
2020-11-13 21:32 ` Stefano Salsano
2020-11-13 21:40 ` Jakub Kicinski
2020-11-13 23:00 ` Andrea Mayer
2020-11-13 23:54 ` Jakub Kicinski [this message]
2020-11-14 1:50 ` Andrea Mayer
2020-11-14 2:01 ` Jakub Kicinski
2020-11-14 2:29 ` Andrea Mayer
2020-11-14 2:52 ` David Ahern
2020-11-13 9:23 ` kernel test robot
2020-11-13 16:57 ` Jakub Kicinski
2020-11-13 17:05 ` David Ahern
2020-11-13 19:00 ` Nathan Chancellor
2020-11-14 3:37 ` David Ahern
2020-11-23 1:13 ` [kbuild-all] " Rong Chen
2020-11-23 17:19 ` Jakub Kicinski
2020-11-07 15:31 ` [net-next,v2,5/5] selftests: add selftest " Andrea Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113155437.7d82550b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=ahabdels.dev@gmail.com \
--cc=andrea.mayer@uniroma2.it \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paolo.lungaroni@cnit.it \
--cc=shrijeet@gmail.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=stefano.salsano@uniroma2.it \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).