From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: hemantk@codeaurora.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bjorn.andersson@linaro.org, ath11k@lists.infradead.org
Subject: Re: [PATCH v2 1/2] bus: mhi: Remove auto-start option
Date: Mon, 16 Nov 2020 10:51:24 +0530 [thread overview]
Message-ID: <20201116052124.GA3926@Mani-XPS-13-9360> (raw)
In-Reply-To: <1600674184-3537-1-git-send-email-loic.poulain@linaro.org>
+ath11k list
On Mon, Sep 21, 2020 at 09:43:03AM +0200, Loic Poulain wrote:
> There is really no point having an auto-start for channels.
> This is confusing for the device drivers, some have to enable the
> channels, others don't have... and waste resources (e.g. pre allocated
> buffers) that may never be used.
>
> This is really up to the MHI device(channel) driver to manage the state
> of its channels.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Applied to mhi-ath11k-immutable branch! This branch will get merged into
mhi-next and ath-next.
Thanks,
Mani
> ---
> v2: split MHI and qrtr changes in dedicated commits
>
> drivers/bus/mhi/core/init.c | 9 ---------
> drivers/bus/mhi/core/internal.h | 1 -
> include/linux/mhi.h | 2 --
> 3 files changed, 12 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index dccc824..8798deb 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -721,7 +721,6 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
> mhi_chan->offload_ch = ch_cfg->offload_channel;
> mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
> mhi_chan->pre_alloc = ch_cfg->auto_queue;
> - mhi_chan->auto_start = ch_cfg->auto_start;
>
> /*
> * If MHI host allocates buffers, then the channel direction
> @@ -1119,11 +1118,6 @@ static int mhi_driver_probe(struct device *dev)
> goto exit_probe;
>
> ul_chan->xfer_cb = mhi_drv->ul_xfer_cb;
> - if (ul_chan->auto_start) {
> - ret = mhi_prepare_channel(mhi_cntrl, ul_chan);
> - if (ret)
> - goto exit_probe;
> - }
> }
>
> ret = -EINVAL;
> @@ -1157,9 +1151,6 @@ static int mhi_driver_probe(struct device *dev)
> if (ret)
> goto exit_probe;
>
> - if (dl_chan && dl_chan->auto_start)
> - mhi_prepare_channel(mhi_cntrl, dl_chan);
> -
> mhi_device_put(mhi_dev);
>
> return ret;
> diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h
> index 5a81a42..73b52a0 100644
> --- a/drivers/bus/mhi/core/internal.h
> +++ b/drivers/bus/mhi/core/internal.h
> @@ -563,7 +563,6 @@ struct mhi_chan {
> bool configured;
> bool offload_ch;
> bool pre_alloc;
> - bool auto_start;
> bool wake_capable;
> };
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index 811e686..0d277c7 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -214,7 +214,6 @@ enum mhi_db_brst_mode {
> * @offload_channel: The client manages the channel completely
> * @doorbell_mode_switch: Channel switches to doorbell mode on M0 transition
> * @auto_queue: Framework will automatically queue buffers for DL traffic
> - * @auto_start: Automatically start (open) this channel
> * @wake-capable: Channel capable of waking up the system
> */
> struct mhi_channel_config {
> @@ -232,7 +231,6 @@ struct mhi_channel_config {
> bool offload_channel;
> bool doorbell_mode_switch;
> bool auto_queue;
> - bool auto_start;
> bool wake_capable;
> };
>
> --
> 2.7.4
>
prev parent reply other threads:[~2020-11-16 5:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 7:43 [PATCH v2 1/2] bus: mhi: Remove auto-start option Loic Poulain
2020-09-21 7:43 ` [PATCH v2 2/2] net: qrtr: Start MHI channels during init Loic Poulain
2020-09-26 7:56 ` Manivannan Sadhasivam
2020-09-26 19:32 ` David Miller
2020-09-27 3:02 ` Manivannan Sadhasivam
2020-11-16 5:22 ` Manivannan Sadhasivam
2020-09-21 14:20 ` [PATCH v2 1/2] bus: mhi: Remove auto-start option Manivannan Sadhasivam
2020-09-21 18:42 ` bbhatt
2020-09-26 8:00 ` Manivannan Sadhasivam
2020-09-27 3:01 ` Manivannan Sadhasivam
2020-11-16 5:21 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116052124.GA3926@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=ath11k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).