From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: netdev@vger.kernel.org, kernel test robot <lkp@intel.com>,
"Jose M . Guisado Gomez" <guigom@riseup.net>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement
Date: Mon, 16 Nov 2020 10:26:48 +0100 [thread overview]
Message-ID: <20201116092648.GA405@salvia> (raw)
In-Reply-To: <20201116034203.7264-1-rdunlap@infradead.org>
Hi,
Thanks for catching up this.
On Sun, Nov 15, 2020 at 07:42:03PM -0800, Randy Dunlap wrote:
> Fix build errors in net/bridge/netfilter/nft_reject_bridge.ko
> by selecting NF_REJECT_IPV4, which provides the missing symbols.
>
> ERROR: modpost: "nf_reject_skb_v4_tcp_reset" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
> ERROR: modpost: "nf_reject_skb_v4_unreach" [net/bridge/netfilter/nft_reject_bridge.ko] undefined!
>
> Fixes: fa538f7cf05a ("netfilter: nf_reject: add reject skbuff creation helpers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: kernel test robot <lkp@intel.com>
> Cc: Jose M. Guisado Gomez <guigom@riseup.net>
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
> Cc: Florian Westphal <fw@strlen.de>
> Cc: netfilter-devel@vger.kernel.org
> Cc: coreteam@netfilter.org
> Cc: Jakub Kicinski <kuba@kernel.org>
> ---
> net/bridge/netfilter/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20201113.orig/net/bridge/netfilter/Kconfig
> +++ linux-next-20201113/net/bridge/netfilter/Kconfig
> @@ -18,6 +18,7 @@ config NFT_BRIDGE_META
> config NFT_BRIDGE_REJECT
> tristate "Netfilter nf_tables bridge reject support"
> depends on NFT_REJECT
> + depends on NF_REJECT_IPV4
I can update the patch here before applying to add:
depends on NF_REJECT_IPV6
as well. It seems both dependencies (IPv4 and IPv6) are missing.
Thanks.
> help
> Add support to reject packets.
>
next prev parent reply other threads:[~2020-11-16 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 3:42 [PATCH net-next] netfilter: nf_reject: bridge: fix build errors due to code movement Randy Dunlap
2020-11-16 9:26 ` Pablo Neira Ayuso [this message]
2020-11-16 16:58 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116092648.GA405@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=guigom@riseup.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).