From: Richard Cochran <richardcochran@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net,
Piotr Kwapulinski <piotr.kwapulinski@intel.com>,
netdev@vger.kernel.org, sassmann@redhat.com,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Andrew Bowers <andrewx.bowers@intel.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [net-next 1/4] i40e: add support for PTP external synchronization clock
Date: Mon, 16 Nov 2020 17:53:25 -0800 [thread overview]
Message-ID: <20201117015325.GB26272@hoboy.vegasvil.org> (raw)
In-Reply-To: <20201116170737.1688ebeb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Nov 16, 2020 at 05:07:37PM -0800, Jakub Kicinski wrote:
> On Fri, 13 Nov 2020 16:10:54 -0800 Tony Nguyen wrote:
> > +/* get PTP pins for ioctl */
> > +#define SIOCGPINS (SIOCDEVPRIVATE + 0)
> > +/* set PTP pins for ioctl */
> > +#define SIOCSPINS (SIOCDEVPRIVATE + 1)
>
> This is unexpected.. is it really normal to declare private device
> IOCTLs to configure PPS pins? Or are you just exposing this so you're
> able to play with GPIOs from user space?
I missed the full patch, but I'd like to point out that we already
have a rather fully featured pin control API. If something is missing
from that API, then please, let's discuss it!
Thanks,
Richard
next prev parent reply other threads:[~2020-11-17 1:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 0:10 [net-next 0/4][pull request] 40GbE Intel Wired LAN Driver Updates 2020-11-13 Tony Nguyen
2020-11-14 0:10 ` [net-next 1/4] i40e: add support for PTP external synchronization clock Tony Nguyen
2020-11-17 1:07 ` Jakub Kicinski
2020-11-17 1:53 ` Richard Cochran [this message]
2020-11-18 16:42 ` Kwapulinski, Piotr
2020-11-14 0:10 ` [net-next 2/4] i40e: remove redundant assignment Tony Nguyen
2020-11-14 0:10 ` [net-next 3/4] i40e: report correct VF link speed when link state is set to enable Tony Nguyen
2020-11-14 0:10 ` [net-next 4/4] igbvf: Refactor traces Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117015325.GB26272@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrewx.bowers@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=piotr.kwapulinski@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).