From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Antonio Cardace <acardace@redhat.com>,
Network Development <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Michal Kubecek <mkubecek@suse.cz>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v3 4/4] selftests: add ring and coalesce selftests
Date: Wed, 18 Nov 2020 15:19:56 -0800 [thread overview]
Message-ID: <20201118151956.277f7fec@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <CA+FuTSevYage147cqyogSfvZN5gtqKngP3RNQe0UoawgtQQ-xA@mail.gmail.com>
On Wed, 18 Nov 2020 16:43:33 -0500 Willem de Bruijn wrote:
> On Tue, Nov 17, 2020 at 12:19 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > Sorry I misremembered it's 4. We can leave that as is.
>
> Instead of having to remember, maybe we should have a file in
> tools/testing/selftest to define constants?
>
> I defined them one-off in tools/testing/selftests/net/udpgso_bench.sh
>
> readonly KSFT_PASS=0
> readonly KSFT_FAIL=1
> readonly KSFT_SKIP=4
>
> along with some other kselftest shell support infra. But having each
> test figure this out independently is duplicative and error prone.
Sounds like a good idea, I was surprised it wasn't already defined in
any lib.
CCing the selftest ML.
next prev parent reply other threads:[~2020-11-18 23:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 23:16 [PATCH net-next v3 1/4] ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define Antonio Cardace
2020-11-13 23:16 ` [PATCH net-next v3 2/4] netdevsim: support ethtool ring and coalesce settings Antonio Cardace
2020-11-16 16:03 ` Michal Kubecek
2020-11-17 0:47 ` Jakub Kicinski
2020-11-13 23:16 ` [PATCH net-next v3 3/4] selftests: extract common functions in ethtool-common.sh Antonio Cardace
2020-11-16 16:17 ` Michal Kubecek
2020-11-16 16:38 ` Antonio Cardace
2020-11-13 23:16 ` [PATCH net-next v3 4/4] selftests: add ring and coalesce selftests Antonio Cardace
2020-11-17 0:45 ` Jakub Kicinski
2020-11-17 11:32 ` Antonio Cardace
2020-11-17 17:15 ` Jakub Kicinski
2020-11-18 21:43 ` Willem de Bruijn
2020-11-18 23:19 ` Jakub Kicinski [this message]
2020-11-16 16:02 ` [PATCH net-next v3 1/4] ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define Michal Kubecek
2020-11-17 0:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118151956.277f7fec@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=acardace@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).