From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F97CC6369E for ; Thu, 19 Nov 2020 00:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9224246E4 for ; Thu, 19 Nov 2020 00:32:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726412AbgKSAcU (ORCPT ); Wed, 18 Nov 2020 19:32:20 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:36944 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725947AbgKSAcU (ORCPT ); Wed, 18 Nov 2020 19:32:20 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kfXs3-007pal-0f; Thu, 19 Nov 2020 01:32:19 +0100 Date: Thu, 19 Nov 2020 01:32:19 +0100 From: Andrew Lunn To: Michael Grzeschik Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, davem@davemloft.net, kernel@pengutronix.de, matthias.schiffer@ew.tq-group.com, woojung.huh@microchip.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH 07/11] net: dsa: microchip: remove superfluous num_ports asignment Message-ID: <20201119003219.GK1804098@lunn.ch> References: <20201118220357.22292-1-m.grzeschik@pengutronix.de> <20201118220357.22292-8-m.grzeschik@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118220357.22292-8-m.grzeschik@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 18, 2020 at 11:03:53PM +0100, Michael Grzeschik wrote: > The variable num_ports is already assigned in the init function. > This patch removes the extra assignment of the variable. > > Signed-off-by: Michael Grzeschik > --- > drivers/net/dsa/microchip/ksz8795.c | 2 -- > drivers/net/dsa/microchip/ksz9477.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c > index 7114902495a0ebb..17dc720df2340b0 100644 > --- a/drivers/net/dsa/microchip/ksz8795.c > +++ b/drivers/net/dsa/microchip/ksz8795.c > @@ -992,8 +992,6 @@ static void ksz8795_config_cpu_port(struct dsa_switch *ds) > u8 remote; > int i; > > - ds->num_ports = dev->port_cnt + 1; > - > /* Switch marks the maximum frame with extra byte as oversize. */ > ksz_cfg(dev, REG_SW_CTRL_2, SW_LEGAL_PACKET_DISABLE, true); > ksz_cfg(dev, S_TAIL_TAG_CTRL, SW_TAIL_TAG_ENABLE, true); > diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c > index abfd3802bb51706..2119965da10ae1e 100644 > --- a/drivers/net/dsa/microchip/ksz9477.c > +++ b/drivers/net/dsa/microchip/ksz9477.c > @@ -1267,8 +1267,6 @@ static void ksz9477_config_cpu_port(struct dsa_switch *ds) > struct ksz_port *p; > int i; > > - ds->num_ports = dev->port_cnt; Please could you give a clue in the commit message that the init function handles the difference between these two, the + 1 in ksz8795. Andrew