From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, dsahern@gmail.com,
jiri@nvidia.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 5/8] selftests: forwarding: Do not configure nexthop objects twice
Date: Thu, 19 Nov 2020 15:08:45 +0200 [thread overview]
Message-ID: <20201119130848.407918-6-idosch@idosch.org> (raw)
In-Reply-To: <20201119130848.407918-1-idosch@idosch.org>
From: Ido Schimmel <idosch@nvidia.com>
routing_nh_obj() is used to configure the nexthop objects employed by
the test, but it is called twice resulting in "RTNETLINK answers: File
exists" messages.
Remove the first call, so that the function is only called after
setup_wait(), when all the interfaces are up and ready.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
tools/testing/selftests/net/forwarding/router_mpath_nh.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/router_mpath_nh.sh b/tools/testing/selftests/net/forwarding/router_mpath_nh.sh
index cf3d26c233e8..6067477ff326 100755
--- a/tools/testing/selftests/net/forwarding/router_mpath_nh.sh
+++ b/tools/testing/selftests/net/forwarding/router_mpath_nh.sh
@@ -312,7 +312,6 @@ setup_prepare()
router1_create
router2_create
- routing_nh_obj
forwarding_enable
}
--
2.28.0
next prev parent reply other threads:[~2020-11-19 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 13:08 [PATCH net-next 0/8] mlxsw: Add support for nexthop objects Ido Schimmel
2020-11-19 13:08 ` [PATCH net-next 1/8] mlxsw: spectrum_router: " Ido Schimmel
2020-11-19 13:08 ` [PATCH net-next 2/8] mlxsw: spectrum_router: Enable resolution of nexthop groups from " Ido Schimmel
2020-11-19 13:08 ` [PATCH net-next 3/8] mlxsw: spectrum_router: Allow programming routes with " Ido Schimmel
2020-11-19 13:08 ` [PATCH net-next 4/8] selftests: mlxsw: Add nexthop objects configuration tests Ido Schimmel
2020-11-19 13:08 ` Ido Schimmel [this message]
2020-11-19 13:08 ` [PATCH net-next 6/8] selftests: forwarding: Test IPv4 routes with IPv6 link-local nexthops Ido Schimmel
2020-11-19 13:08 ` [PATCH net-next 7/8] selftests: forwarding: Add device-only nexthop test Ido Schimmel
2020-11-19 13:08 ` [PATCH net-next 8/8] selftests: forwarding: Add multipath tunneling " Ido Schimmel
2020-11-20 23:30 ` [PATCH net-next 0/8] mlxsw: Add support for nexthop objects patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119130848.407918-6-idosch@idosch.org \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).