From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch,
mkubecek@suse.cz, linux-rdma@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next] net: don't include ethtool.h from netdevice.h
Date: Fri, 20 Nov 2020 14:48:24 -0800 [thread overview]
Message-ID: <20201120144824.2fc3eda0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <9b722328efd90104d0c0819f530c296213c19450.camel@sipsolutions.net>
On Fri, 20 Nov 2020 23:28:28 +0100 Johannes Berg wrote:
> On Fri, 2020-11-20 at 14:13 -0800, Jakub Kicinski wrote:
> > linux/netdevice.h is included in very many places, touching any
> > of its dependecies causes large incremental builds.
> >
> > Drop the linux/ethtool.h include, linux/netdevice.h just needs
> > a forward declaration of struct ethtool_ops.
> >
> > Fix all the places which made use of this implicit include.
>
> > include/net/cfg80211.h | 1 +
>
> Sounds good to me, thanks. Will still cause all wireless drivers to
> rebuild this way though. Maybe I'll see later if something can be done
> about that.
>
> Acked-by: Johannes Berg <johannes@sipsolutions.net>
Same for RDMA, sadly. Both need the firmware version string length.
One simple way to narrow things down would be to include only the uapi
version. Or we can duplicate the define, AFAIR duplicate defines are ok
as long as they are identical.
But not sure it's worth it, I'm happy enough with the 2x reduction in
objects getting rebuilt :)
next prev parent reply other threads:[~2020-11-20 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 22:13 [PATCH net-next] net: don't include ethtool.h from netdevice.h Jakub Kicinski
2020-11-20 22:28 ` Johannes Berg
2020-11-20 22:48 ` Jakub Kicinski [this message]
2020-11-20 23:10 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120144824.2fc3eda0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).