From: Jakub Kicinski <kuba@kernel.org>
To: Ion Badulescu <ionut@badula.org>
Cc: xiakaixu1987@gmail.com, leon@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kaixu Xia <kaixuxia@tencent.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode
Date: Fri, 20 Nov 2020 15:56:37 -0800 [thread overview]
Message-ID: <20201120155637.78f47bc0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <fe835089-3499-0d70-304e-cc3d2e58a8d8@badula.org>
On Fri, 20 Nov 2020 18:41:03 -0500 Ion Badulescu wrote:
> Frankly, no, I don't know of any users, and that unfortunately includes
> myself. I still have two cards in my stash, but they're 64-bit PCI-X, so
> plugging them in would likely require taking a dremel to a 32-bit PCI
> slot to make it open-ended. (They do work in a 32-bit slot.)
>
> Anyway, that filter code could use some fixing in other regards. So
> either we fix it properly (which I can submit a patch for), or clean it
> out for good.
Entirely up to you.
next prev parent reply other threads:[~2020-11-20 23:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 7:50 [PATCH] net: adaptec: remove dead code in set_vlan_mode xiakaixu1987
2020-11-20 23:17 ` Jakub Kicinski
2020-11-20 23:41 ` Ion Badulescu
2020-11-20 23:56 ` Jakub Kicinski [this message]
2020-11-21 0:15 ` Ion Badulescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120155637.78f47bc0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=ionut@badula.org \
--cc=kaixuxia@tencent.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).