From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E6F3C63798 for ; Sat, 21 Nov 2020 21:02:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D33DF20936 for ; Sat, 21 Nov 2020 21:02:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y/CSRY6f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728582AbgKUVCa (ORCPT ); Sat, 21 Nov 2020 16:02:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:60550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728468AbgKUVC3 (ORCPT ); Sat, 21 Nov 2020 16:02:29 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F0CE208C3; Sat, 21 Nov 2020 21:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605992549; bh=blnuHNQgpLeBVd6uoQB+k1nU63B4QU+xzsjn6jEeYQw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y/CSRY6fNFggCxwthXDW4WTHR4HTKEOdFCWXVtgz4tNRM7uQnINYe6tOAKS7u5uoA fgKZBT8q7hd6CWbxt+zqckuG5iO3emIT43vZ+vwznMDa8huKyJOQiDIQAEURzVjaX1 mTDoeWv1p2ttptXsTgzJdF7+7t8GwUjVYGq8j5+0= Date: Sat, 21 Nov 2020 13:02:27 -0800 From: Jakub Kicinski To: Johannes Berg Cc: Florian Westphal , Ido Schimmel , Aleksandr Nogikh , davem@davemloft.net, edumazet@google.com, andreyknvl@google.com, dvyukov@google.com, elver@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, willemdebruijn.kernel@gmail.com, Aleksandr Nogikh , Willem de Bruijn Subject: Re: [PATCH v5 2/3] net: add kcov handle to skb extensions Message-ID: <20201121130227.5136221c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <86c6369a937c760e374c78f5252ffc67cf67b1e1.camel@sipsolutions.net> References: <20201029173620.2121359-1-aleksandrnogikh@gmail.com> <20201029173620.2121359-3-aleksandrnogikh@gmail.com> <20201121160941.GA485907@shredder.lan> <20201121165227.GT15137@breakpoint.cc> <20201121100636.26aaaf8a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201121103529.4b4acbff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <106fc65f0459bc316e89beaf6bd71e823c4c01b7.camel@sipsolutions.net> <20201121125508.4d526dd0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <86c6369a937c760e374c78f5252ffc67cf67b1e1.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 21 Nov 2020 21:58:37 +0100 Johannes Berg wrote: > On Sat, 2020-11-21 at 12:55 -0800, Jakub Kicinski wrote: > > It is more complicated. We can go back to an skb field if this work is > > expected to yield results for mac80211. Would you mind sending a patch? > > I can do that, but I'm not going to be able to do it now/tonight (GMT+1 > here), so probably only Monday/Tuesday or so, sorry. Oh yea, no worries, took someone a month to notice this is broken, as long as it's fixed before the merge window it's fine ;)