From: Jakub Kicinski <kuba@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jamie Iles <jamie@nuviainc.com>,
netdev@vger.kernel.org, Qiushi Wu <wu000273@umn.edu>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [PATCHv3] bonding: wait for sysfs kobject destruction before freeing struct slave
Date: Sat, 21 Nov 2020 13:09:12 -0800 [thread overview]
Message-ID: <20201121130912.68903b8a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <X7fjR8ZB6BVwKS++@kroah.com>
On Fri, 20 Nov 2020 16:39:51 +0100 Greg Kroah-Hartman wrote:
> On Fri, Nov 20, 2020 at 02:28:27PM +0000, Jamie Iles wrote:
> > syzkaller found that with CONFIG_DEBUG_KOBJECT_RELEASE=y, releasing a
> > struct slave device could result in the following splat:
> > This is a potential use-after-free if the sysfs nodes are being accessed
> > whilst removing the struct slave, so wait for the object destruction to
> > complete before freeing the struct slave itself.
>
> Nice, it looks like it should have always been done this way!
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied to net, thanks!
prev parent reply other threads:[~2020-11-21 21:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 8:41 [RESEND PATCH] bonding: wait for sysfs kobject destruction before freeing struct slave Jamie Iles
2020-11-05 12:49 ` Eric Dumazet
2020-11-05 18:11 ` Jamie Iles
2020-11-06 16:17 ` Eric Dumazet
2020-11-13 17:12 ` [PATCHv2] " Jamie Iles
2020-11-17 20:34 ` Jakub Kicinski
2020-11-18 7:58 ` Greg Kroah-Hartman
2020-11-20 14:28 ` [PATCHv3] " Jamie Iles
2020-11-20 15:39 ` Greg Kroah-Hartman
2020-11-21 21:09 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201121130912.68903b8a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andy@greyhouse.net \
--cc=gregkh@linuxfoundation.org \
--cc=j.vosburgh@gmail.com \
--cc=jamie@nuviainc.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).