From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 423A0C5519F for ; Sat, 21 Nov 2020 23:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFD2F20B1F for ; Sat, 21 Nov 2020 23:40:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="B+wCzrPt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726398AbgKUXgM (ORCPT ); Sat, 21 Nov 2020 18:36:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:56648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbgKUXgL (ORCPT ); Sat, 21 Nov 2020 18:36:11 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A093208C3; Sat, 21 Nov 2020 23:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606001771; bh=vE4eAZbWTsmHCn6zLv0gRSIGsOmeO9ynwjm4+1q2BeA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=B+wCzrPtP/Ar9AQWsNNXMNQ9IJyD0k8lOStNnkAIMijVsoT3GtqGEIGKHRZ0105cv BNpRT20qjFanb0eCubIhfIJbamd/d1K5GkzwUU22k9erayAS8k1UHZ645e9xFsQdwL txykSg5qvDxXLE/E26NQ3oRInQ6k9F5Hym/KV2Jo= Date: Sat, 21 Nov 2020 15:36:10 -0800 From: Jakub Kicinski To: Lijun Pan Cc: netdev@vger.kernel.org, sukadev@linux.ibm.com, drt@linux.ibm.com Subject: Re: [PATCH net 01/15] ibmvnic: handle inconsistent login with reset Message-ID: <20201121153605.00862a91@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201120224049.46933-2-ljp@linux.ibm.com> References: <20201120224049.46933-1-ljp@linux.ibm.com> <20201120224049.46933-2-ljp@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 20 Nov 2020 16:40:35 -0600 Lijun Pan wrote: > From: Dany Madden > > Inconsistent login with the vnicserver is causing the device to be > removed. This does not give the device a chance to recover from error > state. This patch schedules a FATAL reset instead to bring the adapter > up. > > Signed-off-by: Dany Madden > Signed-off-by: Lijun Pan Please provide fixes tags for all the patches.