From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH net 1/4] netfilter: nftables_offload: set address type in control dissector
Date: Sun, 22 Nov 2020 11:49:23 +0100 [thread overview]
Message-ID: <20201122104923.GA26512@salvia> (raw)
In-Reply-To: <20201121164442.01b39ffb@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On Sat, Nov 21, 2020 at 04:44:42PM -0800, Jakub Kicinski wrote:
> On Sat, 21 Nov 2020 13:35:58 +0100 Pablo Neira Ayuso wrote:
> > If the address type is missing through the control dissector, then
> > matching on IPv4 and IPv6 addresses does not work.
>
> Doesn't work where? Are you talking about a specific driver?
No.
It does not work for any kind of match, the control flow dissector
needs to be set on.
next prev parent reply other threads:[~2020-11-22 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 12:35 [PATCH net 0/4] Netfilter fixes for net Pablo Neira Ayuso
2020-11-21 12:35 ` [PATCH net 1/4] netfilter: nftables_offload: set address type in control dissector Pablo Neira Ayuso
2020-11-22 0:44 ` Jakub Kicinski
2020-11-22 10:49 ` Pablo Neira Ayuso [this message]
2020-11-21 12:35 ` [PATCH net 2/4] netfilter: nftables_offload: build mask based from the matching bytes Pablo Neira Ayuso
2020-11-21 12:36 ` [PATCH net 3/4] netfilter: ipset: prevent uninit-value in hash_ip6_add Pablo Neira Ayuso
2020-11-21 12:36 ` [PATCH net 4/4] netfilter: nf_tables: avoid false-postive lockdep splat Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201122104923.GA26512@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).