From: Sasha Levin <sashal@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
netdev@vger.kernel.org, Cong Wang <cong.wang@bytedance.com>,
liuzx@knownsec.com, Edward Cree <ecree@solarflare.com>,
stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [Patch stable] netfilter: clear skb->next in NF_HOOK_LIST()
Date: Sun, 22 Nov 2020 12:24:13 -0500 [thread overview]
Message-ID: <20201122172413.GG643756@sasha-vm> (raw)
In-Reply-To: <20201121222249.GU15137@breakpoint.cc>
On Sat, Nov 21, 2020 at 11:22:49PM +0100, Florian Westphal wrote:
>Cong Wang <xiyou.wangcong@gmail.com> wrote:
>> From: Cong Wang <cong.wang@bytedance.com>
>>
>> NF_HOOK_LIST() uses list_del() to remove skb from the linked list,
>> however, it is not sufficient as skb->next still points to other
>> skb. We should just call skb_list_del_init() to clear skb->next,
>> like the rest places which using skb list.
>>
>> This has been fixed in upstream by commit ca58fbe06c54
>> ("netfilter: add and use nf_hook_slow_list()").
>
>Thanks Cong, agree with this change, afaics its applicable to 4.19.y and 5.4.y.
Queued for 5.4 and 4.19, thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-11-22 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 3:43 [Patch stable] netfilter: clear skb->next in NF_HOOK_LIST() Cong Wang
2020-11-21 22:22 ` Florian Westphal
2020-11-22 17:24 ` Sasha Levin [this message]
[not found] ` <tencent_6C31555D2B46173F013EA6CC@qq.com>
2020-11-28 10:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201122172413.GG643756@sasha-vm \
--to=sashal@kernel.org \
--cc=cong.wang@bytedance.com \
--cc=ecree@solarflare.com \
--cc=fw@strlen.de \
--cc=gregkh@linuxfoundation.org \
--cc=liuzx@knownsec.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).