From: Jakub Kicinski <kuba@kernel.org>
To: Nikolay Aleksandrov <nikolay@nvidia.com>
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>, <roopa@nvidia.com>,
<davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<bridge@lists.linux-foundation.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP
Date: Mon, 23 Nov 2020 14:05:19 -0800 [thread overview]
Message-ID: <20201123140519.3bb3db16@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <13cef7c2-cacc-2c24-c0d5-e462b0e3b4df@nvidia.com>
On Mon, 23 Nov 2020 16:25:53 +0200 Nikolay Aleksandrov wrote:
> >>> @@ -156,4 +157,10 @@ struct br_mrp_in_link_hdr {
> >>> __be16 interval;
> >>> };
> >>>
> >>> +struct br_mrp_in_link_status_hdr {
> >>> + __u8 sa[ETH_ALEN];
> >>> + __be16 port_role;
> >>> + __be16 id;
> >>> +};
> >>> +
> >>
> >> I didn't see this struct used anywhere, am I missing anything?
> >
> > Yes, you are right, the struct is not used any. But I put it there as I
> > put the other frame types for MRP.
> >
>
> I see, we don't usually add unused code. The patch is fine as-is and since
> this is already the case for other MRP parts I'm not strictly against it, so:
>
> Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
>
> If Jakub decides to adhere to that rule you can keep my acked-by and just remove
> the struct for v2.
Yes, good catch, let's drop it, we don't want to make too much of
a precedent for using kernel uAPI headers as a place to provide
protocol-related structs if the kernel doesn't need them.
The existing structs are only present in net-next as well, so if you
don't mind Horatiu it'd be good to follow up and remove the unused ones
and move the ones (if any) which are only used by the kernel but not by
the user space <-> kernel API communication out of include/uapi.
next prev parent reply other threads:[~2020-11-23 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 11:14 [PATCH net-next] bridge: mrp: Implement LC mode for MRP Horatiu Vultur
2020-11-23 12:13 ` Nikolay Aleksandrov
2020-11-23 12:31 ` Horatiu Vultur
2020-11-23 14:25 ` Nikolay Aleksandrov
2020-11-23 22:05 ` Jakub Kicinski [this message]
2020-11-23 22:31 ` Horatiu Vultur
2020-11-23 22:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123140519.3bb3db16@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).