[PATCH net-next 00/15] net: phy: add support for shared interrupts (part 3)

* [PATCH net-next 00/15] net: phy: add support for shared interrupts (part 3)
@ 2020-11-23 15:38 Ioana Ciornei
  2020-11-23 15:38 ` [PATCH net-next 01/15] net: phy: intel-xway: implement generic .handle_interrupt() callback Ioana Ciornei
                   ` (16 more replies)
  0 siblings, 17 replies; 21+ messages in thread
From: Ioana Ciornei @ 2020-11-23 15:38 UTC (permalink / raw)
  To: Andrew Lunn, Heiner Kallweit, Russell King, Florian Fainelli,
	Jakub Kicinski, netdev, linux-kernel
  Cc: Ioana Ciornei, Antoine Tenart, Dan Murphy, Divya Koppera,
	Hauke Mehrtens, Jerome Brunet, Marek Vasut, Martin Blumenstingl,
	Mathias Kresin, Neil Armstrong, Oleksij Rempel,
	Philippe Schenker

From: Ioana Ciornei <ioana.ciornei@nxp.com>

This patch set aims to actually add support for shared interrupts in
phylib and not only for multi-PHY devices. While we are at it,
streamline the interrupt handling in phylib.

For a bit of context, at the moment, there are multiple phy_driver ops
that deal with this subject:

- .config_intr() - Enable/disable the interrupt line.

- .ack_interrupt() - Should quiesce any interrupts that may have been
  fired.  It's also used by phylib in conjunction with .config_intr() to
  clear any pending interrupts after the line was disabled, and before
  it is going to be enabled.

- .did_interrupt() - Intended for multi-PHY devices with a shared IRQ
  line and used by phylib to discern which PHY from the package was the
  one that actually fired the interrupt.

- .handle_interrupt() - Completely overrides the default interrupt
  handling logic from phylib. The PHY driver is responsible for checking
  if any interrupt was fired by the respective PHY and choose
  accordingly if it's the one that should trigger the link state machine.

From my point of view, the interrupt handling in phylib has become
somewhat confusing with all these callbacks that actually read the same
PHY register - the interrupt status.  A more streamlined approach would
be to just move the responsibility to write an interrupt handler to the
driver (as any other device driver does) and make .handle_interrupt()
the only way to deal with interrupts.

Another advantage with this approach would be that phylib would gain
support for shared IRQs between different PHY (not just multi-PHY
devices), something which at the moment would require extending every
PHY driver anyway in order to implement their .did_interrupt() callback
and duplicate the same logic as in .ack_interrupt(). The disadvantage
of making .did_interrupt() mandatory would be that we are slightly
changing the semantics of the phylib API and that would increase
confusion instead of reducing it.

What I am proposing is the following:

- As a first step, make the .ack_interrupt() callback optional so that
  we do not break any PHY driver amid the transition.

- Every PHY driver gains a .handle_interrupt() implementation that, for
  the most part, would look like below:

	irq_status = phy_read(phydev, INTR_STATUS);
	if (irq_status < 0) {
		phy_error(phydev);
		return IRQ_NONE;
	}

	if (!(irq_status & irq_mask))
		return IRQ_NONE;

	phy_trigger_machine(phydev);

	return IRQ_HANDLED;

- Remove each PHY driver's implementation of the .ack_interrupt() by
  actually taking care of quiescing any pending interrupts before
  enabling/after disabling the interrupt line.

- Finally, after all drivers have been ported, remove the
  .ack_interrupt() and .did_interrupt() callbacks from phy_driver.

This patch set is part 3 (and final) of the entire change set and it
addresses the remaining PHY drivers that have not been migrated
previosly. Also, it finally removed the .did_interrupt() and
.ack_interrupt() callbacks since they are of no use anymore.

I do not have access to most of these PHY's, therefore I Cc-ed the
latest contributors to the individual PHY drivers in order to have
access, hopefully, to more regression testing.

Ioana Ciornei (15):
  net: phy: intel-xway: implement generic .handle_interrupt() callback
  net: phy: intel-xway: remove the use of .ack_interrupt()
  net: phy: icplus: implement generic .handle_interrupt() callback
  net: phy: icplus: remove the use .ack_interrupt()
  net: phy: meson-gxl: implement generic .handle_interrupt() callback
  net: phy: meson-gxl: remove the use of .ack_callback()
  net: phy: micrel: implement generic .handle_interrupt() callback
  net: phy: micrel: remove the use of .ack_interrupt()
  net: phy: national: implement generic .handle_interrupt() callback
  net: phy: national: remove the use of the .ack_interrupt()
  net: phy: ti: implement generic .handle_interrupt() callback
  net: phy: ti: remove the use of .ack_interrupt()
  net: phy: qsemi: implement generic .handle_interrupt() callback
  net: phy: qsemi: remove the use of .ack_interrupt()
  net: phy: remove the .did_interrupt() and .ack_interrupt() callback

 drivers/net/phy/dp83640.c    | 38 ++++++++++++++++++-
 drivers/net/phy/dp83822.c    | 54 ++++++++++++++++++---------
 drivers/net/phy/dp83848.c    | 47 +++++++++++++++++++++++-
 drivers/net/phy/dp83867.c    | 44 +++++++++++++++++++---
 drivers/net/phy/dp83869.c    | 42 +++++++++++++++++++--
 drivers/net/phy/dp83tc811.c  | 53 ++++++++++++++++++++++++++-
 drivers/net/phy/icplus.c     | 58 +++++++++++++++++++----------
 drivers/net/phy/intel-xway.c | 71 +++++++++++++++++++++---------------
 drivers/net/phy/meson-gxl.c  | 37 +++++++++++++++----
 drivers/net/phy/micrel.c     | 65 +++++++++++++++++++++++++--------
 drivers/net/phy/national.c   | 58 ++++++++++++++++++++++-------
 drivers/net/phy/phy.c        | 48 +-----------------------
 drivers/net/phy/phy_device.c |  2 +-
 drivers/net/phy/qsemi.c      | 42 +++++++++++++++++++--
 include/linux/phy.h          | 19 ++--------
 15 files changed, 497 insertions(+), 181 deletions(-)

Cc: Antoine Tenart <atenart@kernel.org>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: Divya Koppera <Divya.Koppera@microchip.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Mathias Kresin <dev@kresin.me>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Philippe Schenker <philippe.schenker@toradex.com>

-- 
2.28.0

^ permalink raw reply	[flat|nested] 21+ messages in thread