From: Jakub Kicinski <kuba@kernel.org>
To: Limin Wang <lwang.nbl@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: LRO: creating vlan subports affects parent port's LRO settings
Date: Mon, 23 Nov 2020 16:26:39 -0800 [thread overview]
Message-ID: <20201123162639.5d692198@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CACpdL32SRKb8hXzuF_APybip+hyxkXRYoxCW_OMhn0odRSQKuw@mail.gmail.com>
On Thu, 19 Nov 2020 20:37:27 -0500 Limin Wang wrote:
> Under relatively recent kernels (v4.4+), creating a vlan subport on a
> LRO supported parent NIC may turn LRO off on the parent port and
> further render its LRO feature practically unchangeable.
That does sound like an oversight in commit fd867d51f889 ("net/core:
generic support for disabling netdev features down stack").
Are you able to create a patch to fix this?
next prev parent reply other threads:[~2020-11-24 0:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 1:37 LRO: creating vlan subports affects parent port's LRO settings Limin Wang
2020-11-24 0:26 ` Jakub Kicinski [this message]
2020-12-06 0:04 ` Jarod Wilson
2020-12-06 16:49 ` Michal Kubecek
2020-12-06 22:58 ` Jarod Wilson
2020-12-07 3:19 ` Limin Wang
2020-12-07 3:04 ` Limin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123162639.5d692198@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=lwang.nbl@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).