From: Jakub Kicinski <kuba@kernel.org>
To: Matteo Croce <mcroce@linux.microsoft.com>
Cc: Eelco Chaudron <echaudro@redhat.com>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
dev@openvswitch.org, Pravin B Shelar <pshelar@ovn.org>,
bindiyakurle@gmail.com, Ilya Maximets <i.maximets@ovn.org>
Subject: Re: [PATCH net] net: openvswitch: fix TTL decrement action netlink message format
Date: Mon, 23 Nov 2020 17:57:39 -0800 [thread overview]
Message-ID: <20201123175739.13a27aed@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAFnufp1RRtwDLwrWayvyZVPmDjab_dTx50u7xWeNwK7J6azqWw@mail.gmail.com>
On Mon, 23 Nov 2020 20:36:39 +0100 Matteo Croce wrote:
> On Fri, Nov 20, 2020 at 10:12 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > On Thu, 19 Nov 2020 04:04:04 -0500 Eelco Chaudron wrote:
> > > Currently, the openvswitch module is not accepting the correctly formated
> > > netlink message for the TTL decrement action. For both setting and getting
> > > the dec_ttl action, the actions should be nested in the
> > > OVS_DEC_TTL_ATTR_ACTION attribute as mentioned in the openvswitch.h uapi.
> >
> > IOW this change will not break any known user space, correct?
> >
> > But existing OvS user space already expects it to work like you
> > make it work now?
> >
> > What's the harm in leaving it as is?
> >
> > > Fixes: 744676e77720 ("openvswitch: add TTL decrement action")
> > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> >
> > Can we get a review from OvS folks? Matteo looks good to you (as the
> > original author)?
>
> I think that the userspace still has to implement the dec_ttl action;
> by now dec_ttl is implemented with set_ttl().
> So there is no breakage yet.
>
> Eelco, with this fix we will encode the netlink attribute in the same
> way for the kernel and netdev datapath?
We don't allow breaking uAPI. Sounds like the user space never
implemented this and perhaps the nesting is just inconvenient
but not necessarily broken? If it is broken and unusable that
has to be clearly explained in the commit message. I'm dropping
v1 from patchwork.
next prev parent reply other threads:[~2020-11-24 1:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 9:04 [PATCH net] net: openvswitch: fix TTL decrement action netlink message format Eelco Chaudron
2020-11-20 21:12 ` Jakub Kicinski
2020-11-23 19:36 ` Matteo Croce
2020-11-24 1:57 ` Jakub Kicinski [this message]
2020-11-24 11:20 ` Eelco Chaudron
2020-11-24 11:19 ` Eelco Chaudron
2020-11-24 11:18 ` Eelco Chaudron
2020-11-20 22:16 ` Pravin Shelar
2020-11-24 10:51 ` Eelco Chaudron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123175739.13a27aed@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bindiyakurle@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=i.maximets@ovn.org \
--cc=mcroce@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).