From: Andrew Lunn <andrew@lunn.ch>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] net: sfp: add debugfs support
Date: Tue, 24 Nov 2020 01:14:31 +0100 [thread overview]
Message-ID: <20201124001431.GA2031446@lunn.ch> (raw)
In-Reply-To: <E1khJyS-0003UU-9O@rmk-PC.armlinux.org.uk>
On Mon, Nov 23, 2020 at 10:06:16PM +0000, Russell King wrote:
> Add debugfs support to SFP so that the internal state of the SFP state
> machines and hardware signal state can be viewed from userspace, rather
> than having to compile a debug kernel to view state state transitions
> in the kernel log. The 'state' output looks like:
>
> Module state: empty
> Module probe attempts: 0 0
> Device state: up
> Main state: down
> Fault recovery remaining retries: 5
> PHY probe remaining retries: 12
> moddef0: 0
> rx_los: 1
> tx_fault: 1
> tx_disable: 1
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Hi Russell
This looks useful. I always seem to end up recompiling the kernel,
which as you said, this should avoid.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-11-24 0:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 22:06 [PATCH net-next] net: sfp: add debugfs support Russell King
2020-11-24 0:14 ` Andrew Lunn [this message]
2020-11-24 8:41 ` Ido Schimmel
2020-11-24 9:49 ` Russell King - ARM Linux admin
2020-11-24 10:46 ` Ido Schimmel
2020-12-02 13:03 ` Russell King - ARM Linux admin
2020-12-02 16:59 ` Jakub Kicinski
2020-12-02 17:01 ` Jakub Kicinski
2020-12-07 16:06 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124001431.GA2031446@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).