From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60539C2D0E4 for ; Tue, 24 Nov 2020 09:49:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3AEE20684 for ; Tue, 24 Nov 2020 09:49:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="m2UNpRTT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731476AbgKXJtU (ORCPT ); Tue, 24 Nov 2020 04:49:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728886AbgKXJtT (ORCPT ); Tue, 24 Nov 2020 04:49:19 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EC83C0613D6 for ; Tue, 24 Nov 2020 01:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wWnhMX8z2TZm6R/eePyUTOLI0uVQfiq552roOfXPs1A=; b=m2UNpRTTJ9a1uyAYYLBsKLteN GREBFJHepoAysNWf5aOCNy3nL3auOL5qsOfzL3f5SAK9+hSws+1Pa7YBIdiL0DI3iD0ptjW2nuCCy hZ4nDL3IzUeJevIUQbVhSyxgNNRQnBCl1wTcDU+3CsKeFqUVhjIikGtS2czM+hnAki2jXooEUbxE5 KK2OvO+0e0i71OYNsYr26muPFNCBo+GAHLQLLcDas67qtQEazQIITmaxrWftzI4keVOZGMeQSfMB1 Tm0SiKOcDdVdv/uMrEQGzN2pqxOTQcw8gnjn3cs9jVzS0FaSzCGi2ksfwWccmBiRnVs4v3bJFC3fy Ifn5GN1BQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35436) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khUwn-0007R0-LW; Tue, 24 Nov 2020 09:49:17 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1khUwm-0007F5-WD; Tue, 24 Nov 2020 09:49:17 +0000 Date: Tue, 24 Nov 2020 09:49:16 +0000 From: Russell King - ARM Linux admin To: Ido Schimmel Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, Jakub Kicinski Subject: Re: [PATCH net-next] net: sfp: add debugfs support Message-ID: <20201124094916.GD1551@shell.armlinux.org.uk> References: <20201124001431.GA2031446@lunn.ch> <20201124084151.GA722671@shredder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124084151.GA722671@shredder.lan> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Nov 24, 2020 at 10:41:51AM +0200, Ido Schimmel wrote: > On Tue, Nov 24, 2020 at 01:14:31AM +0100, Andrew Lunn wrote: > > On Mon, Nov 23, 2020 at 10:06:16PM +0000, Russell King wrote: > > > Add debugfs support to SFP so that the internal state of the SFP state > > > machines and hardware signal state can be viewed from userspace, rather > > > than having to compile a debug kernel to view state state transitions > > > in the kernel log. The 'state' output looks like: > > > > > > Module state: empty > > > Module probe attempts: 0 0 > > > Device state: up > > > Main state: down > > > Fault recovery remaining retries: 5 > > > PHY probe remaining retries: 12 > > > moddef0: 0 > > > rx_los: 1 > > > tx_fault: 1 > > > tx_disable: 1 > > > > > > Signed-off-by: Russell King > > > > Hi Russell > > > > This looks useful. I always seem to end up recompiling the kernel, > > which as you said, this should avoid. > > FWIW, another option is to use drgn [1]. Especially when the state is > queried from the kernel and not hardware. We are using that in mlxsw > [2][3]. Presumably that requires /proc/kcore support, which 32-bit ARM doesn't have. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!