From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45590C56201 for ; Tue, 24 Nov 2020 23:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2DB42145D for ; Tue, 24 Nov 2020 23:49:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wtrND54x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389771AbgKXXtH (ORCPT ); Tue, 24 Nov 2020 18:49:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:44060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728749AbgKXXtG (ORCPT ); Tue, 24 Nov 2020 18:49:06 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16FA42100A; Tue, 24 Nov 2020 23:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606261746; bh=UOVjsou1NphjeKLK7OSCErMOgnbH953scN8q24eTPyQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wtrND54xp4J5NS8JQxIuumSPUvsXL4Eqlvr2g6OQMunUB/FUHwatgHDYQp7Y++/ob umRua8Z62dCAye0fwBBnkzFBwcX8fM7Ln0k3ob4nbUrru0bhbQdGgf8HwmQV4o9zj0 k2n/rqtCj1pBnYOCD5Nuj0c5XhkGyfAR5kZTG0yc= Date: Tue, 24 Nov 2020 15:49:04 -0800 From: Jakub Kicinski To: Andrea Mayer Cc: "David S. Miller" , David Ahern , Alexey Kuznetsov , Hideaki YOSHIFUJI , Shuah Khan , Shrijeet Mukherjee , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Nathan Chancellor , Stefano Salsano , Paolo Lungaroni , Ahmed Abdelsalam Subject: Re: [net-next v3 0/8] seg6: add support for SRv6 End.DT4/DT6 behavior Message-ID: <20201124154904.0699f4c1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201123182857.4640-1-andrea.mayer@uniroma2.it> References: <20201123182857.4640-1-andrea.mayer@uniroma2.it> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 23 Nov 2020 19:28:48 +0100 Andrea Mayer wrote: > - Patch 1 is needed to solve a pre-existing issue with tunneled packets > when a sniffer is attached; > > - Patch 2 improves the management of the seg6local attributes used by the > SRv6 behaviors; > > - Patch 3 adds support for optional attributes in SRv6 behaviors; > > - Patch 4 introduces two callbacks used for customizing the > creation/destruction of a SRv6 behavior; > > - Patch 5 is the core patch that adds support for the SRv6 End.DT4 > behavior; > > - Patch 6 introduces the VRF support for SRv6 End.DT6 behavior; > > - Patch 7 adds the selftest for SRv6 End.DT4 behavior; > > - Patch 8 adds the selftest for SRv6 End.DT6 (VRF mode) behavior; > > - Patch 9 adds the vrftable attribute for End.DT4/DT6 behaviors in iproute2. LGTM! Please address the nit and repost without the iproute2 patch. Mixing the iproute2 patch in has confused patchwork: https://patchwork.kernel.org/project/netdevbpf/list/?series=389667&state=* Note how it thinks that the iproute2 patch is part of the kernel series. This build bot-y thing is pretty new. I'll add a suggestion to our process documentation not to mix patches. > I would like to thank David Ahern for his support during the development of > this patchset. Should I take this to mean that David has review the code off-list?