From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51B38C5519F for ; Fri, 27 Nov 2020 17:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17A1A221EB for ; Fri, 27 Nov 2020 17:15:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732110AbgK0RPM (ORCPT ); Fri, 27 Nov 2020 12:15:12 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:53152 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbgK0RPM (ORCPT ); Fri, 27 Nov 2020 12:15:12 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kihKs-0099nq-Kt; Fri, 27 Nov 2020 18:15:06 +0100 Date: Fri, 27 Nov 2020 18:15:06 +0100 From: Andrew Lunn To: Steen Hegelund Cc: "David S. Miller" , Jakub Kicinski , Masahiro Yamada , Lars Povlsen , Bjarni Jonasson , Microchip Linux Driver Support , Alexandre Belloni , Microsemi List , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver Message-ID: <20201127171506.GW2073444@lunn.ch> References: <20201127133307.2969817-1-steen.hegelund@microchip.com> <20201127133307.2969817-3-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201127133307.2969817-3-steen.hegelund@microchip.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is a very large driver, which is going to make it slow to review. > +static int sparx5_probe_port(struct sparx5 *sparx5, > + struct device_node *portnp, > + struct phy *serdes, > + u32 portno, > + struct sparx5_port_config *conf) > +{ > + phy_interface_t phy_mode = conf->phy_mode; > + struct sparx5_port *spx5_port; > + struct net_device *ndev; > + struct phylink *phylink; > + int err; > + > + err = sparx5_create_targets(sparx5); > + if (err) > + return err; > + ndev = sparx5_create_netdev(sparx5, portno); > + if (IS_ERR(ndev)) { > + dev_err(sparx5->dev, "Could not create net device: %02u\n", portno); > + return PTR_ERR(ndev); > + } > + spx5_port = netdev_priv(ndev); > + spx5_port->of_node = portnp; > + spx5_port->serdes = serdes; > + spx5_port->pvid = NULL_VID; > + spx5_port->signd_internal = true; > + spx5_port->signd_active_high = true; > + spx5_port->signd_enable = true; > + spx5_port->flow_control = false; > + spx5_port->max_vlan_tags = SPX5_PORT_MAX_TAGS_NONE; > + spx5_port->vlan_type = SPX5_VLAN_PORT_TYPE_UNAWARE; > + spx5_port->custom_etype = 0x8880; /* Vitesse */ > + conf->portmode = conf->phy_mode; > + spx5_port->conf.speed = SPEED_UNKNOWN; > + spx5_port->conf.power_down = true; > + sparx5->ports[portno] = spx5_port; > +struct net_device *sparx5_create_netdev(struct sparx5 *sparx5, u32 portno) > +{ > + struct net_device *ndev; > + struct sparx5_port *spx5_port; > + int err; > + > + ndev = devm_alloc_etherdev(sparx5->dev, sizeof(struct sparx5_port)); > + if (!ndev) > + return ERR_PTR(-ENOMEM); > + ... > + err = register_netdev(ndev); > + if (err) { > + dev_err(sparx5->dev, "netdev registration failed\n"); > + return ERR_PTR(err); > + } This is one of the classic bugs in network drivers. As soon as you call register_netdev() the interface is live. The network stack can start using it. But you have not finished initialzing spx5_port. So bad things are going to happen. Andrew