From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Dan Murphy <dmurphy@ti.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples
Date: Sat, 28 Nov 2020 14:49:12 -0800 [thread overview]
Message-ID: <20201128144912.5d5a9430@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> (raw)
In-Reply-To: <4fe99bbc-4037-8542-449c-86a30fb1190a@pengutronix.de>
On Fri, 27 Nov 2020 20:35:55 +0100 Marc Kleine-Budde wrote:
> On 11/27/20 5:27 PM, Jakub Kicinski wrote:
> > On Fri, 27 Nov 2020 10:13:01 +0100 Marc Kleine-Budde wrote:
> >> On 10/26/20 4:36 PM, Krzysztof Kozlowski wrote:
> >>> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> >>> These are simple defines so they could be used in DTS but they will not
> >>> have the same meaning:
> >>> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> >>> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
> >>>
> >>> Correct the interrupt flags, assuming the author of the code wanted same
> >>> logical behavior behind the name "ACTIVE_xxx", this is:
> >>> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
> >>> ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >>> Acked-by: Rob Herring <robh@kernel.org>
> >>> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> # for tcan4x5x.txt
> >>
> >> Jakub, can you queue this patch for net/master?
> >
> > Sure! Are these correct?
> >
> > Fixes: a1a8b4594f8d ("NFC: pn544: i2c: Add DTS Documentation")
> > Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver")
>
> ACK:
Applied to net and queued for stable, thanks!
prev parent reply other threads:[~2020-11-28 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 15:36 [RESEND PATCH v2] dt-bindings: net: correct interrupt flags in examples Krzysztof Kozlowski
2020-11-27 9:13 ` Marc Kleine-Budde
2020-11-27 16:27 ` Jakub Kicinski
2020-11-27 19:35 ` Marc Kleine-Budde
2020-11-28 22:49 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128144912.5d5a9430@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=krzk@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).