From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346AFC83029 for ; Sat, 28 Nov 2020 22:12:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01C9B2224C for ; Sat, 28 Nov 2020 22:12:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389505AbgK1VuB (ORCPT ); Sat, 28 Nov 2020 16:50:01 -0500 Received: from mslow2.mail.gandi.net ([217.70.178.242]:49838 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387687AbgK1UWP (ORCPT ); Sat, 28 Nov 2020 15:22:15 -0500 Received: from relay4-d.mail.gandi.net (unknown [217.70.183.196]) by mslow2.mail.gandi.net (Postfix) with ESMTP id D5B113A05FE for ; Sat, 28 Nov 2020 20:10:54 +0000 (UTC) X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 89999E0003; Sat, 28 Nov 2020 20:07:51 +0000 (UTC) Date: Sat, 28 Nov 2020 21:07:50 +0100 From: Alexandre Belloni To: Russell King - ARM Linux admin Cc: Andrew Lunn , Steen Hegelund , "David S. Miller" , Jakub Kicinski , Masahiro Yamada , Lars Povlsen , Bjarni Jonasson , Microchip Linux Driver Support , Microsemi List , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver Message-ID: <20201128200750.GK1296649@piout.net> References: <20201127133307.2969817-1-steen.hegelund@microchip.com> <20201127133307.2969817-3-steen.hegelund@microchip.com> <20201128190616.GF2191767@lunn.ch> <20201128193707.GP1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201128193707.GP1551@shell.armlinux.org.uk> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Russell, On 28/11/2020 19:37:07+0000, Russell King - ARM Linux admin wrote: > On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > > +static void sparx5_phylink_mac_config(struct phylink_config *config, > > > + unsigned int mode, > > > + const struct phylink_link_state *state) > > > +{ > > > + struct sparx5_port *port = netdev_priv(to_net_dev(config->dev)); > > > + struct sparx5_port_config conf; > > > + int err = 0; > > > + > > > + conf = port->conf; > > > + conf.autoneg = state->an_enabled; > > > + conf.pause = state->pause; > > > + conf.duplex = state->duplex; > > > + conf.power_down = false; > > > + conf.portmode = state->interface; > > > + > > > + if (state->speed == SPEED_UNKNOWN) { > > > + /* When a SFP is plugged in we use capabilities to > > > + * default to the highest supported speed > > > + */ > > > > This looks suspicious. > > > > Russell, please could you look through this? > > Maybe if I was copied on the patch submission... I don't have the > patches, and searching google for them is a faff, especially > when > > site:kernel.org 20201127133307.2969817-1-steen.hegelund@microchip.com > > gives: > > Your search - site:kernel.org > 20201127133307.2969817-1-steen.hegelund@microchip.com - did not > match any documents. Suggestions: Make sure that all words are > spelled correctly. Try different keywords. Try more general > keywords. > http://lore.kernel.org/r/20201127133307.2969817-1-steen.hegelund@microchip.com does the right redirect. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com