From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390AEC3E8C5 for ; Sun, 29 Nov 2020 11:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6A0C2076C for ; Sun, 29 Nov 2020 11:31:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="o9DSjXLi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727418AbgK2LbF (ORCPT ); Sun, 29 Nov 2020 06:31:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbgK2LbF (ORCPT ); Sun, 29 Nov 2020 06:31:05 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6BB0C0613CF; Sun, 29 Nov 2020 03:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QGqxcbLsjyEPen3iQTZ0RxUUyFbEosqdtxEiZVBNOQY=; b=o9DSjXLisplQ2VS/byxKhdRhg f64c0/IAuqUvnOfYh4lpgkFcWki0xPSDe8JwjUuYYeIAYiH5IcoifyYuQG4whccYbRrDMHu1xfd2o CGljGi+Ibdtia5qC3ZrHBrzcEZKz4ptgH3p1B45NirUXdbCO7+o20ej5RpoJR1o+EK7bcfVRbpp+0 pSCl8CW3GYnZIudVxaCt3qK5cbszBOmZO1xe4PJTvEj3yeVPp69JjTuUDVNyHKkL3iu/X6NeSADZT sShDZU8Z3rXt5SrbTMNVilSf2W3F2pqReO7+qahwjhdHBaIP2Ss+4dOIwVwA8bURXqSrgKqWYjcYB cTU8+METw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:37554) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjKuJ-0005YX-5I; Sun, 29 Nov 2020 11:30:19 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kjKuI-0003y6-TH; Sun, 29 Nov 2020 11:30:18 +0000 Date: Sun, 29 Nov 2020 11:30:18 +0000 From: Russell King - ARM Linux admin To: Andrew Lunn Cc: Steen Hegelund , "David S. Miller" , Jakub Kicinski , Masahiro Yamada , Lars Povlsen , Bjarni Jonasson , Microchip Linux Driver Support , Alexandre Belloni , Microsemi List , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver Message-ID: <20201129113018.GI1605@shell.armlinux.org.uk> References: <20201127133307.2969817-1-steen.hegelund@microchip.com> <20201127133307.2969817-3-steen.hegelund@microchip.com> <20201128190616.GF2191767@lunn.ch> <20201128222828.GQ1551@shell.armlinux.org.uk> <20201129105245.GG1605@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201129105245.GG1605@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Nov 29, 2020 at 10:52:45AM +0000, Russell King - ARM Linux admin wrote: > There are other issues too. This is also wrong: + if (port->ndev && port->ndev->phydev) + status->link = port->ndev->phydev->link; phylink already deals with that situation. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!