From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8BA8C71156 for ; Mon, 30 Nov 2020 14:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4321F20709 for ; Mon, 30 Nov 2020 14:31:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="ITOa3aou" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727747AbgK3Obb (ORCPT ); Mon, 30 Nov 2020 09:31:31 -0500 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:54095 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726953AbgK3Oba (ORCPT ); Mon, 30 Nov 2020 09:31:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1606746690; x=1638282690; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xCCce2MsvHOXRDAX3rYlHsIDzQTw2AvoabSKgeQ4ZWo=; b=ITOa3aoulNA6N3LWyjBdaP0y4n91OK7NMAvCNMnhZ7+Dl5quOYipqj6E 2axB8MTr1RZM2ZB6jtnkuhjRiFdGDUndq4mfKBC3/suofor1NK0LEXtik 1Ulg9R5B8AluvNEdukqg4ISleVUJ33Q6NcumGhOL6+2CkIXn8lssMVFEc zLCaLhOpdtiCpxSJfkkNKSl1JCUeruDsvsDupNfMwzi4qvFIbawZW81Xn aqsezrNXTsvJjSrQL+43ICYyfqXt7o2LDaINOkx/VieBtCywwSwPHwADY abpDyuyCYi4dcA0DCTrfO3Sw+Ox0T90s757zdJtDtlxSY+GEHW8w0MQRk w==; IronPort-SDR: Et6cmmbHAj54TAIK8UskcUEkToRY84K25xlyJEQ3SKRiYjzB+rgfnIz3pJM08FAGMYxS5xhvEO 3U/2ow7jrZA1ATyvHDZ8AjvrNAiOYU58gZR9kYHthHdApjNoQCBYZPq9iB9KNWwb5pXlJSBdbN Zzi1+9KWEZFswSX+t3VkX3Os192QzIzML/gjIwuM5IMLfH2XL6KWgf6zNjeU3Mk6pT11rJnyg9 t4bxcu5mt75oFt74HD7tkeL1xSJ4PbaHmxAHJZGyILRzJ9noo5d5AKnOxBmKP3x4+7k/RLTrBc RII= X-IronPort-AV: E=Sophos;i="5.78,381,1599548400"; d="scan'208";a="97986070" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 30 Nov 2020 07:30:24 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 30 Nov 2020 07:30:24 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Mon, 30 Nov 2020 07:30:23 -0700 Date: Mon, 30 Nov 2020 15:30:23 +0100 From: Steen Hegelund To: Russell King - ARM Linux admin CC: Andrew Lunn , "David S. Miller" , Jakub Kicinski , Masahiro Yamada , Lars Povlsen , Bjarni Jonasson , Microchip Linux Driver Support , Alexandre Belloni , Microsemi List , , Subject: Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver Message-ID: <20201130143023.csjyuhs6uke7dtu6@mchp-dev-shegelun> References: <20201127133307.2969817-1-steen.hegelund@microchip.com> <20201127133307.2969817-3-steen.hegelund@microchip.com> <20201128190616.GF2191767@lunn.ch> <20201128222828.GQ1551@shell.armlinux.org.uk> <20201129105245.GG1605@shell.armlinux.org.uk> <20201129113018.GI1605@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Disposition: inline In-Reply-To: <20201129113018.GI1605@shell.armlinux.org.uk> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 29.11.2020 11:30, Russell King - ARM Linux admin wrote: >EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >On Sun, Nov 29, 2020 at 10:52:45AM +0000, Russell King - ARM Linux admin wrote: >> There are other issues too. > >This is also wrong: > >+ if (port->ndev && port->ndev->phydev) >+ status->link = port->ndev->phydev->link; > >phylink already deals with that situation. So if I need the link state, what interface should I then use to get it? > >-- >RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ >FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! Thanks for your comments BR Steen --------------------------------------- Steen Hegelund steen.hegelund@microchip.com