netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ryan Barnett <ryan.barnett@rockwellcollins.com>,
	Conrad Ratschan <conrad.ratschan@rockwellcollins.com>,
	Hugo Cornelis <hugo.cornelis@essensium.com>,
	Arnout Vandecappelle <arnout.vandecappelle@essensium.com>
Subject: Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface
Date: Tue, 1 Dec 2020 19:41:00 +0100	[thread overview]
Message-ID: <20201201184100.GN2073444@lunn.ch> (raw)
In-Reply-To: <20201201083408.51006-1-jean.pihet@newoldbits.com>

On Tue, Dec 01, 2020 at 09:34:08AM +0100, Jean Pihet wrote:
> Add support for RGMII in 100 and 1000 Mbps.
> 
> Adjust the CPU port settings from the host interface settings: interface
> MII type, speed, duplex.

Hi Jean

You have still not explained why this is needed. Why? is always the
important question to answer in the commit message. The What? is
obvious from reading the patch. Why does you board need this, when no
over board does?

Thanks
	Andrew

  reply	other threads:[~2020-12-01 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  8:34 [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface Jean Pihet
2020-12-01 18:41 ` Andrew Lunn [this message]
2020-12-01 18:58   ` Jean Pihet
2020-12-01 19:48     ` Vladimir Oltean
2020-12-07 19:41       ` Jean Pihet
2020-12-01 20:45     ` Andrew Lunn
2020-12-07 19:43       ` Jean Pihet
2020-12-08  2:11         ` Andrew Lunn
     [not found]           ` <CAORVsuX9w_JHjM88YhT02k93vbF3SZmxwYt-E_Tth8xTP04V2w@mail.gmail.com>
2020-12-08 14:15             ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201201184100.GN2073444@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=arnout.vandecappelle@essensium.com \
    --cc=conrad.ratschan@rockwellcollins.com \
    --cc=hugo.cornelis@essensium.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ryan.barnett@rockwellcollins.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).