From: David Miller <davem@davemloft.net>
To: m.grzeschik@pengutronix.de
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
kernel@pengutronix.de, matthias.schiffer@ew.tq-group.com,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct
Date: Mon, 07 Dec 2020 07:01:23 -0800 (PST) [thread overview]
Message-ID: <20201207.070123.2205337287463864568.davem@davemloft.net> (raw)
In-Reply-To: <20201207125627.30843-4-m.grzeschik@pengutronix.de>
From: Michael Grzeschik <m.grzeschik@pengutronix.de>
Date: Mon, 7 Dec 2020 13:56:24 +0100
> @@ -991,13 +1090,16 @@ static void ksz8_port_setup(struct ksz_device *dev, int port, bool cpu_port)
> static void ksz8_config_cpu_port(struct dsa_switch *ds)
> {
> struct ksz_device *dev = ds->priv;
> + struct ksz8 *ksz8 = dev->priv;
> + const u8 *regs = ksz8->regs;
> + const u32 *masks = ksz8->masks;
> struct ksz_port *p;
> u8 remote;
> int i;
>
Please use reverse christmas tree ordering for local variables.
Thank you.
next prev parent reply other threads:[~2020-12-07 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 12:56 [PATCH v5 0/6] microchip: add support for ksz88x3 driver family Michael Grzeschik
2020-12-07 12:56 ` [PATCH v5 1/6] net: dsa: microchip: ksz8795: change drivers prefix to be generic Michael Grzeschik
2020-12-07 12:56 ` [PATCH v5 2/6] net: dsa: microchip: ksz8795: move cpu_select_interface to extra function Michael Grzeschik
2020-12-07 12:56 ` [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct Michael Grzeschik
2020-12-07 14:11 ` kernel test robot
2020-12-07 15:01 ` David Miller [this message]
2020-12-07 20:02 ` Tristram.Ha
2020-12-07 21:44 ` Michael Grzeschik
2020-12-15 16:31 ` Michael Grzeschik
2020-12-11 4:21 ` kernel test robot
2020-12-07 12:56 ` [PATCH v5 4/6] net: dsa: microchip: ksz8795: add support for ksz88xx chips Michael Grzeschik
2020-12-16 6:33 ` Tristram.Ha
2021-02-01 18:37 ` Michael Grzeschik
2020-12-07 12:56 ` [PATCH v5 5/6] net: dsa: microchip: Add Microchip KSZ8863 SPI based driver support Michael Grzeschik
2020-12-07 12:56 ` [PATCH v5 6/6] dt-bindings: net: dsa: document additional Microchip KSZ8863/8873 switch Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207.070123.2205337287463864568.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=m.grzeschik@pengutronix.de \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).