From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: davem@davemloft.net, kuba@kernel.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, jianxin.pan@amlogic.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, khilman@baylibre.com,
narmstrong@baylibre.com, jbrunet@baylibre.com, andrew@lunn.ch,
f.fainelli@gmail.com
Subject: Re: [PATCH RFC v2 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay
Date: Mon, 7 Dec 2020 13:17:16 -0600 [thread overview]
Message-ID: <20201207191716.GA647149@robh.at.kernel.org> (raw)
In-Reply-To: <20201115185210.573739-2-martin.blumenstingl@googlemail.com>
On Sun, Nov 15, 2020 at 07:52:06PM +0100, Martin Blumenstingl wrote:
> Amlogic Meson G12A, G12B and SM1 SoCs have a more advanced RGMII RX
> delay register which allows picoseconds precision. Deprecate the old
> "amlogic,rx-delay-ns" in favour of a new "amlogic,rgmii-rx-delay-ps"
> property.
>
> For older SoCs the only known supported values were 0ns and 2ns. The new
> SoCs have 200ps precision and support RGMII RX delays between 0ps and
> 3000ps.
>
> While here, also update the description of the RX delay to indicate
> that:
> - with "rgmii" or "rgmii-id" the RX delay should be specified
> - with "rgmii-id" or "rgmii-rxid" the RX delay is added by the PHY so
> any configuration on the MAC side is ignored
> - with "rmii" the RX delay is not applicable and any configuration is
> ignored
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> .../bindings/net/amlogic,meson-dwmac.yaml | 61 +++++++++++++++++--
> 1 file changed, 56 insertions(+), 5 deletions(-)
Don't we have common properties for this now?
>
> diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> index 6b057b117aa0..62a1e92a645c 100644
> --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> @@ -74,17 +74,68 @@ allOf:
> Any configuration is ignored when the phy-mode is set to "rmii".
>
> amlogic,rx-delay-ns:
> + deprecated: true
> enum:
> - 0
> - 2
> default: 0
> + description:
> + The internal RGMII RX clock delay in nanoseconds. Deprecated, use
> + amlogic,rgmii-rx-delay-ps instead.
> +
> + amlogic,rgmii-rx-delay-ps:
> + default: 0
> description:
> The internal RGMII RX clock delay (provided by this IP block) in
> - nanoseconds. When phy-mode is set to "rgmii" then the RX delay
> - should be explicitly configured. When the phy-mode is set to
> - either "rgmii-id" or "rgmii-rxid" the RX clock delay is already
> - provided by the PHY. Any configuration is ignored when the
> - phy-mode is set to "rmii".
> + picoseconds. When phy-mode is set to "rgmii" or "rgmii-id" then
> + the RX delay should be explicitly configured. When the phy-mode
> + is set to either "rgmii-id" or "rgmii-rxid" the RX clock delay
> + is already provided by the PHY so any configuration here is
> + ignored. Also any configuration is ignored when the phy-mode is
> + set to "rmii".
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - amlogic,meson8b-dwmac
> + - amlogic,meson8m2-dwmac
> + - amlogic,meson-gxbb-dwmac
> + - amlogic,meson-axg-dwmac
> + then:
> + properties:
> + amlogic,rgmii-rx-delay-ps:
> + enum:
> + - 0
> + - 2000
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - amlogic,meson-g12a-dwmac
> + then:
> + properties:
> + amlogic,rgmii-rx-delay-ps:
> + enum:
> + - 0
> + - 200
> + - 400
> + - 600
> + - 800
> + - 1000
> + - 1200
> + - 1400
> + - 1600
> + - 1800
> + - 2000
> + - 2200
> + - 2400
> + - 2600
> + - 2800
> + - 3000
>
> properties:
> compatible:
> --
> 2.29.2
>
next prev parent reply other threads:[~2020-12-07 19:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 18:52 [PATCH RFC v2 0/5] dwmac-meson8b: picosecond precision RX delay support Martin Blumenstingl
2020-11-15 18:52 ` [PATCH RFC v2 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay Martin Blumenstingl
2020-11-17 2:01 ` Andrew Lunn
2020-11-17 18:32 ` Florian Fainelli
2020-12-07 19:17 ` Rob Herring [this message]
2020-12-13 16:59 ` Martin Blumenstingl
2020-12-15 13:40 ` Rob Herring
2020-11-15 18:52 ` [PATCH RFC v2 2/5] net: stmmac: dwmac-meson8b: fix enabling the timing-adjustment clock Martin Blumenstingl
2020-11-17 2:02 ` Andrew Lunn
2020-11-17 18:34 ` Florian Fainelli
2020-11-15 18:52 ` [PATCH RFC v2 3/5] net: stmmac: dwmac-meson8b: use picoseconds for the RGMII RX delay Martin Blumenstingl
2020-11-17 2:04 ` Andrew Lunn
2020-11-17 18:36 ` Florian Fainelli
2020-11-17 22:50 ` Martin Blumenstingl
2020-11-15 18:52 ` [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function Martin Blumenstingl
2020-11-17 2:05 ` Andrew Lunn
2020-11-17 18:36 ` Florian Fainelli
2020-11-15 18:52 ` [PATCH RFC v2 5/5] net: stmmac: dwmac-meson8b: add support for the RGMII RX delay on G12A Martin Blumenstingl
2020-11-17 2:06 ` Andrew Lunn
2020-11-17 18:37 ` Florian Fainelli
2020-11-17 22:55 ` [PATCH RFC v2 0/5] dwmac-meson8b: picosecond precision RX delay support Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207191716.GA647149@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).