From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Tobias Waldekranz <tobias@waldekranz.com>,
davem@davemloft.net, kuba@kernel.org, vivien.didelot@gmail.com,
f.fainelli@gmail.com, j.vosburgh@gmail.com, vfalico@gmail.com,
andy@greyhouse.net, netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support
Date: Tue, 8 Dec 2020 18:26:24 +0100 [thread overview]
Message-ID: <20201208172624.GC2475207@lunn.ch> (raw)
In-Reply-To: <20201208112350.kuvlaxqto37igczk@skbuf>
> There are two points to be made:
> - Recently we have seen people with non-DSA (pure switchdev) hardware
> being compelled to write DSA drivers, because they noticed that a
> large part of the middle layer had already been written, and it
> presents an API with a lot of syntactic sugar. Maybe there is a
> larger issue here in that the switchdev offloading APIs are fairly
> bulky and repetitive, but that does not mean that we should be
> encouraging the attitude "come to DSA, we have cookies".
> https://lwn.net/ml/linux-kernel/20201125232459.378-1-lukma@denx.de/
We often see developers stumbling around in the dark, not knowing the
subsystems and how best to solve a problem. So i would not read too
much into that particular email discussion. It was just another
example of we the maintainers, trying to get an understanding of the
hardware and help point a developer in the right direction. We don't
consider DSA the solution for all switch problems.
We do however have a growing number of pure switchdev drivers now, so
it might be time to take a look and see what is common, and pull some
code out of the drivers and into a library. This is a common pattern
you see all over the kernel. One driver often leads the way with a new
subsystem, but it is not until you have a few different drivers using
the subsystem do you have a real feel for what is common and can be
pulled out of the drivers and into a framework.
Andrew
next prev parent reply other threads:[~2020-12-08 17:27 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 9:13 [PATCH v3 net-next 0/4] net: dsa: Link aggregation support Tobias Waldekranz
2020-12-02 9:13 ` [PATCH v3 net-next 1/4] net: bonding: Notify ports about their initial state Tobias Waldekranz
2020-12-02 19:09 ` Jay Vosburgh
2020-12-02 21:52 ` Tobias Waldekranz
2020-12-03 0:39 ` Jay Vosburgh
2020-12-03 8:16 ` Tobias Waldekranz
2020-12-02 9:13 ` [PATCH v3 net-next 2/4] net: dsa: Link aggregation support Tobias Waldekranz
2020-12-02 10:07 ` Vladimir Oltean
2020-12-02 10:51 ` Tobias Waldekranz
2020-12-02 18:58 ` Jakub Kicinski
2020-12-02 21:29 ` Tobias Waldekranz
2020-12-02 21:32 ` Vladimir Oltean
2020-12-03 16:24 ` Vladimir Oltean
2020-12-03 20:53 ` Tobias Waldekranz
2020-12-03 21:09 ` Andrew Lunn
2020-12-03 21:35 ` Tobias Waldekranz
2020-12-04 0:35 ` Vladimir Oltean
2020-12-03 21:57 ` Vladimir Oltean
2020-12-03 23:12 ` Tobias Waldekranz
2020-12-04 0:56 ` Vladimir Oltean
2020-12-07 21:49 ` Tobias Waldekranz
2020-12-04 1:33 ` Andrew Lunn
2020-12-04 4:18 ` Florian Fainelli
2020-12-07 21:56 ` Tobias Waldekranz
2020-12-03 20:48 ` Vladimir Oltean
2020-12-04 2:20 ` Andrew Lunn
2020-12-07 21:19 ` Tobias Waldekranz
2020-12-07 23:26 ` Andrew Lunn
2020-12-09 8:57 ` Tobias Waldekranz
2020-12-09 14:27 ` Andrew Lunn
2020-12-09 15:21 ` Tobias Waldekranz
2020-12-09 23:03 ` Andrew Lunn
2020-12-04 4:04 ` Florian Fainelli
2020-12-08 11:23 ` Vladimir Oltean
2020-12-08 15:33 ` Tobias Waldekranz
2020-12-08 16:37 ` Vladimir Oltean
2020-12-09 8:37 ` Tobias Waldekranz
2020-12-09 10:53 ` Vladimir Oltean
2020-12-09 14:11 ` Tobias Waldekranz
2020-12-09 16:04 ` Vladimir Oltean
2020-12-09 22:01 ` Tobias Waldekranz
2020-12-09 22:21 ` Vladimir Oltean
2020-12-10 10:18 ` Tobias Waldekranz
2020-12-09 22:59 ` Andrew Lunn
2020-12-10 1:05 ` Vladimir Oltean
2020-12-09 14:23 ` Andrew Lunn
2020-12-09 23:17 ` Vladimir Oltean
2020-12-08 17:26 ` Andrew Lunn [this message]
2020-12-11 20:50 ` Tobias Waldekranz
2020-12-12 14:26 ` Vladimir Oltean
2020-12-13 21:18 ` Tobias Waldekranz
2020-12-14 0:12 ` Vladimir Oltean
2020-12-14 11:42 ` Ido Schimmel
2020-12-16 15:15 ` Tobias Waldekranz
2020-12-16 18:48 ` Ido Schimmel
2020-12-14 9:41 ` Tobias Waldekranz
2020-12-02 9:13 ` [PATCH v3 net-next 3/4] net: dsa: mv88e6xxx: " Tobias Waldekranz
2020-12-02 9:13 ` [PATCH v3 net-next 4/4] net: dsa: tag_dsa: Support reception of packets from LAG devices Tobias Waldekranz
2020-12-04 3:58 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208172624.GC2475207@lunn.ch \
--to=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=tobias@waldekranz.com \
--cc=vfalico@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).