From: Rob Herring <robh@kernel.org>
To: Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: hauke@hauke-m.de, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: net: dsa: lantiq, lantiq-gswip: add example for xRX330
Date: Wed, 9 Dec 2020 21:40:25 -0600 [thread overview]
Message-ID: <20201210034025.GA1610317@robh.at.kernel.org> (raw)
In-Reply-To: <20201206132713.13452-3-olek2@wp.pl>
On Sun, Dec 06, 2020 at 02:27:13PM +0100, Aleksander Jan Bajkowski wrote:
> Add compatible string and example for xRX300 and xRX330.
>
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> .../bindings/net/dsa/lantiq-gswip.txt | 110 +++++++++++++++++-
> 1 file changed, 109 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt b/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
> index 886cbe8ffb38..7a90a6a1b065 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
> @@ -3,7 +3,8 @@ Lantiq GSWIP Ethernet switches
>
> Required properties for GSWIP core:
>
> -- compatible : "lantiq,xrx200-gswip" for the embedded GSWIP in the
> +- compatible : "lantiq,xrx200-gswip", "lantiq,xrx300-gswip" or
> + "lantiq,xrx330-gswip" for the embedded GSWIP in the
> xRX200 SoC
> - reg : memory range of the GSWIP core registers
> : memory range of the GSWIP MDIO registers
> @@ -141,3 +142,110 @@ switch@e108000 {
> };
> };
> };
> +
> +Ethernet switch on the GRX330 SoC:
A new compatible string doesn't justify a new example.
Consider converting to DT schema.
> +
> +switch@e108000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "lantiq,xrx300-gswip";
> + reg = < 0xe108000 0x3100 /* switch */
> + 0xe10b100 0xd8 /* mdio */
> + 0xe10b1d8 0x130 /* mii */
> + >;
> + dsa,member = <0 0>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@1 {
> + reg = <1>;
> + label = "lan1";
> + phy-mode = "internal";
> + phy-handle = <&phy1>;
> + };
> +
> + port@2 {
> + reg = <2>;
> + label = "lan2";
> + phy-mode = "internal";
> + phy-handle = <&phy2>;
> + };
> +
> + port@3 {
> + reg = <3>;
> + label = "lan3";
> + phy-mode = "internal";
> + phy-handle = <&phy3>;
> + };
> +
> + port@4 {
> + reg = <4>;
> + label = "lan4";
> + phy-mode = "internal";
> + phy-handle = <&phy4>;
> + };
> +
> + port@6 {
> + reg = <0x6>;
> + label = "cpu";
> + ethernet = <ð0>;
> + };
> + };
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "lantiq,xrx200-mdio";
> + reg = <0>;
> +
> + phy1: ethernet-phy@1 {
> + reg = <0x1>;
> + };
> + phy2: ethernet-phy@2 {
> + reg = <0x2>;
> + };
> + phy3: ethernet-phy@3 {
> + reg = <0x3>;
> + };
> + phy4: ethernet-phy@4 {
> + reg = <0x4>;
> + };
> + };
> +
> + gphy-fw {
> + compatible = "lantiq,xrx330-gphy-fw", "lantiq,gphy-fw";
> + lantiq,rcu = <&rcu0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gphy@20 {
> + reg = <0x20>;
> +
> + resets = <&reset0 31 30>;
> + reset-names = "gphy";
> + };
> +
> + gphy@68 {
> + reg = <0x68>;
> +
> + resets = <&reset0 29 28>;
> + reset-names = "gphy";
> + };
> +
> + gphy@ac {
> + reg = <0xac>;
> +
> + resets = <&reset0 28 13>;
> + reset-names = "gphy";
> + };
> +
> + gphy@264 {
> + reg = <0x264>;
> +
> + resets = <&reset0 10 10>;
> + reset-names = "gphy";
> + };
> + };
> +};
> --
> 2.20.1
>
prev parent reply other threads:[~2020-12-10 3:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 13:27 [PATCH v2 0/2] net: dsa: lantiq: add support for xRX300 and xRX330 Aleksander Jan Bajkowski
2020-12-06 13:27 ` [PATCH v2 1/2] net: dsa: lantiq: allow to use all GPHYs on " Aleksander Jan Bajkowski
2020-12-06 18:54 ` Vladimir Oltean
2020-12-07 21:43 ` Jakub Kicinski
2020-12-09 14:46 ` kernel test robot
2020-12-10 8:20 ` kernel test robot
2020-12-06 13:27 ` [PATCH v2 2/2] dt-bindings: net: dsa: lantiq, lantiq-gswip: add example for xRX330 Aleksander Jan Bajkowski
2020-12-10 3:40 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210034025.GA1610317@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).