From: Jonathan Lemon <jonathan.lemon@gmail.com>
To: <netdev@vger.kernel.org>, <edumazet@google.com>,
<willemdebruijn.kernel@gmail.com>
Cc: <kernel-team@fb.com>
Subject: [PATCH 0/9 v1 RFC] Generic zcopy_* functions
Date: Fri, 18 Dec 2020 12:16:24 -0800 [thread overview]
Message-ID: <20201218201633.2735367-1-jonathan.lemon@gmail.com> (raw)
From: Jonathan Lemon <bsd@fb.com>
This is set of cleanup patches for zerocopy which are intended
to allow a introduction of a different zerocopy implementation.
The top level api will use the skb_zcopy_*() functions, while
the current TCP specific zerocopy would use the sock_zerocopy_*()
calls.
There should be no functional changes from these patches.
Patch 1:
Move zerocopy bits from tx_flags into zc_flags for clarity.
These bits will be used in the RX path in the future.
Patch 2: remove dead function
Patch 3:
Replace sock_zerocopy_put() with skb_zcopy_put(), moving
the zerocopy logic into sock_zerocopy_callback(). Push the
refcounting into the callback, since not all implemenetations
will have a refcount.
Patch 4: rename sock_zerocopy_get for consistency.
Patch 5:
Add an optional skb parameter to callback, allowing access to
the attached skb from the callback.
Patch 6:
Add skb_zcopy_put_abort, and move zerocopy logic into the
callback function. There unfortunately is still a check
against the callback type here.
Patch 7:
Set the skb zc_flags from the ubuf being attached, instead
of a fixed value, allowing different initialization types.
Patch 8: Replace open-coded assignments
Patch 9: Relocate skb_zcopy_clear() in skb_release_data()
Jonathan Lemon (9):
net: group skb_shinfo zerocopy related bits together.
skbuff: remove unused skb_zcopy_abort function
skbuff: replace sock_zerocopy_put() with skb_zcopy_put()
skbuff: replace sock_zerocopy_get with skb_zcopy_get
skbuff: Add skb parameter to the ubuf zerocopy callback
skbuff: Call sock_zerocopy_put_abort from skb_zcopy_put_abort
skbuff: add zc_flags to ubuf_info for ubuf setup
tap/tun: use skb_zcopy_set() instead of open coded assignment
skbuff: Call skb_zcopy_clear() before unref'ing fragments
drivers/net/tap.c | 6 +--
drivers/net/tun.c | 6 +--
drivers/net/xen-netback/common.h | 3 +-
drivers/net/xen-netback/interface.c | 4 +-
drivers/net/xen-netback/netback.c | 7 +--
drivers/vhost/net.c | 4 +-
include/linux/skbuff.h | 77 +++++++++++++++--------------
net/core/skbuff.c | 48 +++++++++---------
net/ipv4/ip_output.c | 3 +-
net/ipv4/tcp.c | 6 +--
net/ipv6/ip6_output.c | 3 +-
net/kcm/kcmsock.c | 4 +-
12 files changed, 85 insertions(+), 86 deletions(-)
--
2.24.1
next reply other threads:[~2020-12-18 20:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 20:16 Jonathan Lemon [this message]
2020-12-18 20:16 ` [PATCH 1/9 v1 RFC] net: group skb_shinfo zerocopy related bits together Jonathan Lemon
2020-12-18 20:16 ` [PATCH 2/9 v1 RFC] skbuff: remove unused skb_zcopy_abort function Jonathan Lemon
2020-12-18 20:16 ` [PATCH 3/9 v1 RFC] skbuff: replace sock_zerocopy_put() with skb_zcopy_put() Jonathan Lemon
2020-12-19 18:46 ` Willem de Bruijn
2020-12-21 19:18 ` Jonathan Lemon
2020-12-21 22:49 ` Willem de Bruijn
2020-12-18 20:16 ` [PATCH 4/9 v1 RFC] skbuff: replace sock_zerocopy_get with skb_zcopy_get Jonathan Lemon
2020-12-18 20:16 ` [PATCH 5/9 v1 RFC] skbuff: Add skb parameter to the ubuf zerocopy callback Jonathan Lemon
2020-12-18 20:16 ` [PATCH 6/9 v1 RFC] skbuff: Call sock_zerocopy_put_abort from skb_zcopy_put_abort Jonathan Lemon
2020-12-18 20:16 ` [PATCH 7/9 v1 RFC] skbuff: add zc_flags to ubuf_info for ubuf setup Jonathan Lemon
2020-12-18 20:16 ` [PATCH 8/9 v1 RFC] tap/tun: use skb_zcopy_set() instead of open coded assignment Jonathan Lemon
2020-12-18 20:16 ` [PATCH 9/9 v1 RFC] skbuff: Call skb_zcopy_clear() before unref'ing fragments Jonathan Lemon
2020-12-18 20:49 ` [PATCH 0/9 v1 RFC] Generic zcopy_* functions Willem de Bruijn
2020-12-18 21:16 ` Jonathan Lemon
2020-12-19 19:00 ` Willem de Bruijn
2020-12-21 19:50 ` Jonathan Lemon
2020-12-21 22:52 ` Willem de Bruijn
2020-12-22 0:07 ` Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218201633.2735367-1-jonathan.lemon@gmail.com \
--to=jonathan.lemon@gmail.com \
--cc=edumazet@google.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).