From: Andrew Lunn <andrew@lunn.ch>
To: DENG Qingfang <dqfext@gmail.com>
Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Greg Ungerer <gerg@kernel.org>,
Rene van Dorst <opensource@vdorst.com>,
John Crispin <john@phrozen.org>
Subject: Re: [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible
Date: Sat, 19 Dec 2020 17:26:01 +0100 [thread overview]
Message-ID: <20201219162601.GE3008889@lunn.ch> (raw)
In-Reply-To: <20201219162153.23126-1-dqfext@gmail.com>
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -2688,7 +2688,7 @@ static const struct mt753x_info mt753x_table[] = {
> };
>
> static const struct of_device_id mt7530_of_match[] = {
> - { .compatible = "mediatek,mt7621", .data = &mt753x_table[ID_MT7621], },
> + { .compatible = "mediatek,mt7621-gsw", .data = &mt753x_table[ID_MT7621], },
> { .compatible = "mediatek,mt7530", .data = &mt753x_table[ID_MT7530], },
> { .compatible = "mediatek,mt7531", .data = &mt753x_table[ID_MT7531], },
> { /* sentinel */ },
This will break backwards compatibility with existing DT blobs. You
need to keep the old "mediatek,mt7621", but please add a comment that
it is deprecated.
Andrew
next prev parent reply other threads:[~2020-12-19 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 16:21 [RFC PATCH net-next] net: dsa: mt7530: rename MT7621 compatible DENG Qingfang
2020-12-19 16:26 ` Andrew Lunn [this message]
2020-12-19 17:07 ` Florian Fainelli
2020-12-19 19:48 ` Vladimir Oltean
2020-12-20 4:48 ` DENG Qingfang
2020-12-20 7:49 ` Vladimir Oltean
2020-12-20 8:36 ` DENG Qingfang
2020-12-20 9:01 ` Vladimir Oltean
2020-12-21 7:32 ` Chuanhong Guo
2020-12-20 9:07 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201219162601.GE3008889@lunn.ch \
--to=andrew@lunn.ch \
--cc=Landen.Chao@mediatek.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gerg@kernel.org \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource@vdorst.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).