From: Jakub Kicinski <kuba@kernel.org>
To: Nick Lowe <nick.lowe@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] igb: Enable RSS for Intel I211 Ethernet Controller
Date: Mon, 21 Dec 2020 14:11:34 -0800 [thread overview]
Message-ID: <20201221141134.55ad507a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201221191549.4311-1-nick.lowe@gmail.com>
On Mon, 21 Dec 2020 19:15:49 +0000 Nick Lowe wrote:
> The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (RSS) queues.
> It should not be excluded from having this feature enabled.
>
> Via commit c883de9fd787b6f49bf825f3de3601aeb78a7114
> E1000_MRQC_ENABLE_RSS_4Q was renamed to E1000_MRQC_ENABLE_RSS_MQ to
> indicate that this is a generic bit flag to enable queues and not
> a flag that is specific to devices that support 4 queues
>
> The bit flag enables 2, 4 or 8 queues appropriately depending on the part.
>
> Tested with a multicore CPU and frames were then distributed as expected.
>
> This issue appears to have been introduced because of confusion caused
> by the prior name.
>
> Signed-off-by: Nick Lowe <nick.lowe@gmail.com>
Please repost CCing the maintainers.
next prev parent reply other threads:[~2020-12-21 22:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 19:15 [PATCH net] igb: Enable RSS for Intel I211 Ethernet Controller Nick Lowe
2020-12-21 22:11 ` Jakub Kicinski [this message]
2020-12-21 22:25 Nick Lowe
2021-01-31 23:17 ` Matt Corallo
2021-02-01 16:47 ` Jakub Kicinski
2021-02-01 18:32 ` Nguyen, Anthony L
2021-02-01 19:45 ` Jakub Kicinski
2021-02-01 20:06 ` Nick Lowe
2021-02-01 20:21 ` Matt Corallo
2021-02-01 20:23 ` Nick Lowe
2021-02-01 20:33 ` Jakub Kicinski
2021-05-03 12:32 ` Nick Lowe
2021-05-03 18:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221141134.55ad507a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.lowe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).