From: "Pali Rohár" <pali@kernel.org> To: "Russell King" <linux@armlinux.org.uk>, "Andrew Lunn" <andrew@lunn.ch>, "Heiner Kallweit" <hkallweit1@gmail.com>, "David S. Miller" <davem@davemloft.net>, "Jakub Kicinski" <kuba@kernel.org>, "Marek Behún" <kabel@kernel.org> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Date: Wed, 30 Dec 2020 16:47:55 +0100 [thread overview] Message-ID: <20201230154755.14746-5-pali@kernel.org> (raw) In-Reply-To: <20201230154755.14746-1-pali@kernel.org> SFP GPON module Ubiquiti U-Fiber Instant has in its EEPROM stored nonsense information. It claims that support all transceiver types including 10G Ethernet which is not truth. So clear all claimed modes and set only one mode which module supports: 1000baseX_Full. This change finally allows to detect and use SFP GPON module Ubiquiti U-Fiber Instant on Linux system. EEPROM content of this SFP module is (where XX is serial number): 00: 02 04 0b ff ff ff ff ff ff ff ff 03 0c 00 14 c8 ???........??.?? 10: 00 00 00 00 55 42 4e 54 20 20 20 20 20 20 20 20 ....UBNT 20: 20 20 20 20 00 18 e8 29 55 46 2d 49 4e 53 54 41 .??)UF-INSTA 30: 4e 54 20 20 20 20 20 20 34 20 20 20 05 1e 00 36 NT 4 ??.6 40: 00 06 00 00 55 42 4e 54 XX XX XX XX XX XX XX XX .?..UBNTXXXXXXXX 50: 20 20 20 20 31 34 30 31 32 33 20 20 60 80 02 41 140123 `??A Signed-off-by: Pali Rohár <pali@kernel.org> --- drivers/net/phy/sfp-bus.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c index 20b91f5dfc6e..4cf874fb5c5b 100644 --- a/drivers/net/phy/sfp-bus.c +++ b/drivers/net/phy/sfp-bus.c @@ -44,6 +44,17 @@ static void sfp_quirk_2500basex(const struct sfp_eeprom_id *id, phylink_set(modes, 2500baseX_Full); } +static void sfp_quirk_ubnt_uf_instant(const struct sfp_eeprom_id *id, + unsigned long *modes) +{ + /* Ubiquiti U-Fiber Instant module claims that support all transceiver + * types including 10G Ethernet which is not truth. So clear all claimed + * modes and set only one mode which module supports: 1000baseX_Full. + */ + phylink_zero(modes); + phylink_set(modes, 1000baseX_Full); +} + static const struct sfp_quirk sfp_quirks[] = { { // Alcatel Lucent G-010S-P can operate at 2500base-X, but @@ -63,6 +74,10 @@ static const struct sfp_quirk sfp_quirks[] = { .vendor = "HUAWEI", .part = "MA5671A", .modes = sfp_quirk_2500basex, + }, { + .vendor = "UBNT", + .part = "UF-INSTANT", + .modes = sfp_quirk_ubnt_uf_instant, }, }; -- 2.20.1
next prev parent reply other threads:[~2020-12-30 15:49 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-30 15:47 [PATCH 0/4] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár 2020-12-30 15:47 ` [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár 2020-12-30 16:10 ` Russell King - ARM Linux admin 2020-12-30 16:56 ` Pali Rohár 2020-12-30 17:05 ` Russell King - ARM Linux admin 2020-12-30 17:13 ` Andrew Lunn 2020-12-30 17:43 ` Pali Rohár 2020-12-30 19:09 ` Russell King - ARM Linux admin 2020-12-30 19:49 ` Andrew Lunn 2020-12-31 12:14 ` Pali Rohár 2020-12-31 15:09 ` Andrew Lunn 2020-12-31 15:40 ` Pali Rohár 2020-12-31 15:30 ` Andrew Lunn 2020-12-31 17:00 ` Pali Rohár 2020-12-31 17:13 ` Andrew Lunn 2021-01-02 1:49 ` Pali Rohár 2021-01-03 2:25 ` Thomas Schreiber 2021-01-03 2:41 ` Pali Rohár 2021-01-06 14:55 ` Pali Rohár 2021-01-06 15:21 ` Russell King - ARM Linux admin 2021-01-06 15:23 ` Russell King - ARM Linux admin 2021-01-06 15:27 ` Russell King - ARM Linux admin 2021-01-06 15:35 ` Pali Rohár 2020-12-30 19:30 ` Andrew Lunn 2020-12-30 19:39 ` Russell King - ARM Linux admin 2020-12-30 17:31 ` Pali Rohár 2020-12-30 19:18 ` Russell King - ARM Linux admin 2020-12-30 15:47 ` [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF Pali Rohár 2020-12-30 16:11 ` Russell King - ARM Linux admin 2020-12-30 17:06 ` Pali Rohár 2020-12-30 17:27 ` Marek Behún 2020-12-30 19:12 ` Russell King - ARM Linux admin 2020-12-31 13:52 ` Pali Rohár 2020-12-30 15:47 ` [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Pali Rohár 2020-12-30 16:13 ` Russell King - ARM Linux admin 2020-12-30 16:57 ` Pali Rohár 2020-12-30 17:06 ` Russell King - ARM Linux admin 2020-12-30 17:17 ` Andrew Lunn 2020-12-30 17:32 ` Pali Rohár 2020-12-30 15:47 ` Pali Rohár [this message] 2021-01-06 15:37 ` [PATCH v2 0/3] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár 2021-01-06 15:37 ` [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár 2021-01-07 2:02 ` Andrew Lunn 2021-01-07 9:08 ` Pali Rohár 2021-01-07 17:19 ` Andrew Lunn 2021-01-07 17:40 ` Russell King - ARM Linux admin 2021-01-07 19:18 ` Pali Rohár 2021-01-07 19:17 ` Pali Rohár 2021-01-07 19:45 ` Russell King - ARM Linux admin 2021-01-07 20:21 ` Marek Behún 2021-01-08 0:49 ` Pali Rohár 2021-01-06 15:37 ` [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Pali Rohár 2021-01-07 16:54 ` Andrew Lunn 2021-01-09 15:46 ` Russell King - ARM Linux admin 2021-01-09 15:54 ` Andrew Lunn 2021-01-09 16:27 ` Russell King - ARM Linux admin 2021-01-09 19:14 ` Pali Rohár 2021-01-09 23:19 ` Russell King - ARM Linux admin 2021-01-09 23:50 ` Pali Rohár 2021-01-06 15:37 ` [PATCH v2 3/3] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár 2021-01-07 16:51 ` Andrew Lunn 2021-01-11 11:39 ` [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár 2021-01-11 11:39 ` [PATCH v3 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár 2021-01-11 15:28 ` Marek Behún 2021-01-11 11:39 ` [PATCH v3 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár 2021-01-11 15:32 ` Marek Behún 2021-01-12 13:33 ` [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár 2021-01-18 9:34 ` Pali Rohár 2021-01-25 14:09 ` Pali Rohár 2021-01-25 14:16 ` Russell King - ARM Linux admin 2021-01-25 14:23 ` Pali Rohár 2021-01-25 14:42 ` Russell King - ARM Linux admin 2021-01-25 14:47 ` Pali Rohár 2021-01-25 15:41 ` Andrew Lunn 2021-01-25 15:02 ` [PATCH v4 " Pali Rohár 2021-01-25 15:02 ` [PATCH v4 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár 2021-01-25 15:02 ` [PATCH v4 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár 2021-01-28 21:50 ` [PATCH v4 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201230154755.14746-5-pali@kernel.org \ --to=pali@kernel.org \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=hkallweit1@gmail.com \ --cc=kabel@kernel.org \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=netdev@vger.kernel.org \ --subject='Re: [PATCH 4/4] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).