From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97AC9C433DB for ; Wed, 30 Dec 2020 18:58:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 588A422242 for ; Wed, 30 Dec 2020 18:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726348AbgL3S60 (ORCPT ); Wed, 30 Dec 2020 13:58:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgL3S6Z (ORCPT ); Wed, 30 Dec 2020 13:58:25 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A30AC061573 for ; Wed, 30 Dec 2020 10:57:45 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1kugez-00075i-W8; Wed, 30 Dec 2020 19:57:26 +0100 Date: Wed, 30 Dec 2020 19:57:25 +0100 From: Florian Westphal To: Visa Hankala Cc: Florian Westphal , Steffen Klassert , Herbert Xu , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH v2] xfrm: Fix wraparound in xfrm_policy_addr_delta() Message-ID: <20201230185725.GD30823@breakpoint.cc> References: <20201230160902.sYeDeDSVSPay2WBC@hankala.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230160902.sYeDeDSVSPay2WBC@hankala.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Visa Hankala wrote: > Use three-way comparison for address components to avoid integer > wraparound in the result of xfrm_policy_addr_delta(). This ensures > that the search trees are built and traversed correctly. > > Treat IPv4 and IPv6 similarly by returning 0 when prefixlen == 0. > Prefix /0 has only one equivalence class. Acked-by: Florian Westphal