From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net] docs: net: fix documentation on .ndo_get_stats
Date: Mon, 4 Jan 2021 09:53:09 -0800 [thread overview]
Message-ID: <20210104095309.28682a9b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210104104227.oqx6xt76k5snmhs6@skbuf>
On Mon, 4 Jan 2021 12:42:27 +0200 Vladimir Oltean wrote:
> On Wed, Dec 30, 2020 at 07:45:24PM -0800, Jakub Kicinski wrote:
> > Fix calling context.
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > ---
> > Documentation/networking/netdevices.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
> > index 5a85fcc80c76..a80676f5477d 100644
> > --- a/Documentation/networking/netdevices.rst
> > +++ b/Documentation/networking/netdevices.rst
> > @@ -64,8 +64,8 @@ struct net_device synchronization rules
> > Context: process
> >
> > ndo_get_stats:
> > - Synchronization: dev_base_lock rwlock.
> > - Context: nominally process, but don't sleep inside an rwlock
> > + Synchronization: rtnl_lock() semaphore, or RCU.
> > + Context: atomic
> >
> > ndo_start_xmit:
> > Synchronization: __netif_tx_lock spinlock.
>
> And what happened to dev_base_lock? Did it suddenly go away?
I thought all callers switched to RCU. You investigated this in depth,
did I miss something? I'm sending this correction because I have a
series which adds to other sections of this file and this jumped out
to me as incorrect.
next prev parent reply other threads:[~2021-01-04 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 3:45 [PATCH net] docs: net: fix documentation on .ndo_get_stats Jakub Kicinski
2021-01-04 10:42 ` Vladimir Oltean
2021-01-04 17:53 ` Jakub Kicinski [this message]
2021-01-05 1:03 ` Vladimir Oltean
2021-01-05 1:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104095309.28682a9b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).