From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
daniel@iogearbox.net, kernel-team@fb.com
Subject: Re: [PATCH bpf-next 3/3] selftests/bpf: add tests for user- and non-CO-RE BPF_CORE_READ() variants
Date: Mon, 4 Jan 2021 19:46:44 -0800 [thread overview]
Message-ID: <20210105034644.5thpans6alifiq65@ast-mbp> (raw)
In-Reply-To: <20201218235614.2284956-4-andrii@kernel.org>
On Fri, Dec 18, 2020 at 03:56:14PM -0800, Andrii Nakryiko wrote:
> +
> +/* shuffled layout for relocatable (CO-RE) reads */
> +struct callback_head___shuffled {
> + void (*func)(struct callback_head___shuffled *head);
> + struct callback_head___shuffled *next;
> +};
> +
> +struct callback_head k_probe_in = {};
> +struct callback_head___shuffled k_core_in = {};
> +
> +struct callback_head *u_probe_in = 0;
> +struct callback_head___shuffled *u_core_in = 0;
> +
> +long k_probe_out = 0;
> +long u_probe_out = 0;
> +
> +long k_core_out = 0;
> +long u_core_out = 0;
> +
> +int my_pid = 0;
> +
> +SEC("raw_tracepoint/sys_enter")
> +int handler(void *ctx)
> +{
> + int pid = bpf_get_current_pid_tgid() >> 32;
> +
> + if (my_pid != pid)
> + return 0;
> +
> + /* next pointers for kernel address space have to be initialized from
> + * BPF side, user-space mmaped addresses are stil user-space addresses
> + */
> + k_probe_in.next = &k_probe_in;
> + __builtin_preserve_access_index(({k_core_in.next = &k_core_in;}));
> +
> + k_probe_out = (long)BPF_PROBE_READ(&k_probe_in, next, next, func);
> + k_core_out = (long)BPF_CORE_READ(&k_core_in, next, next, func);
> + u_probe_out = (long)BPF_PROBE_READ_USER(u_probe_in, next, next, func);
> + u_core_out = (long)BPF_CORE_READ_USER(u_core_in, next, next, func);
I don't understand what the test suppose to demonstrate.
co-re relocs work for kernel btf only.
Are you saying that 'struct callback_head' happened to be used by user space
process that allocated it in user memory. And that is the same struct as
being used by the kernel? So co-re relocs that apply against the kernel
will sort-of work against the data of user space process because
the user space is using the same struct? That sounds convoluted.
I struggle to see the point of patch 1:
+#define bpf_core_read_user(dst, sz, src) \
+ bpf_probe_read_user(dst, sz, (const void *)__builtin_preserve_access_index(src))
co-re for user structs? Aren't they uapi? No reloc is needed.
next prev parent reply other threads:[~2021-01-05 3:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 23:56 [PATCH bpf-next 0/3] Add user-space and non-CO-RE variants of BPF_CORE_READ() Andrii Nakryiko
2020-12-18 23:56 ` [PATCH bpf-next 1/3] libbpf: add user-space variants of BPF_CORE_READ() family of macros Andrii Nakryiko
2020-12-18 23:56 ` [PATCH bpf-next 2/3] libbpf: add non-CO-RE variants of BPF_CORE_READ() macro family Andrii Nakryiko
2020-12-18 23:56 ` [PATCH bpf-next 3/3] selftests/bpf: add tests for user- and non-CO-RE BPF_CORE_READ() variants Andrii Nakryiko
2021-01-05 3:46 ` Alexei Starovoitov [this message]
2021-01-05 5:08 ` Andrii Nakryiko
2021-01-05 19:03 ` Alexei Starovoitov
2021-01-05 21:03 ` Andrii Nakryiko
2021-01-06 6:09 ` Alexei Starovoitov
2021-01-06 10:10 ` Gilad Reti
2021-01-06 23:25 ` Andrii Nakryiko
2021-01-07 20:00 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105034644.5thpans6alifiq65@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).