From: Martin KaFai Lau <kafai@fb.com>
To: Sean Young <sean@mess.org>
Cc: "Yonghong Song" <yhs@fb.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Song Liu" <songliubraving@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Nathan Chancellor" <natechancellor@gmail.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Quentin Monnet" <quentin@isovalent.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-doc@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH v3 0/4] btf: support ints larger than 128 bits
Date: Tue, 5 Jan 2021 11:51:13 -0800 [thread overview]
Message-ID: <20210105195113.lr3mc5ma2rvej4r6@kafai-mbp> (raw)
In-Reply-To: <cover.1609855479.git.sean@mess.org>
On Tue, Jan 05, 2021 at 02:45:30PM +0000, Sean Young wrote:
> clang supports arbitrary length ints using the _ExtInt extension. This
> can be useful to hold very large values, e.g. 256 bit or 512 bit types.
>
> Larger types (e.g. 1024 bits) are possible but I am unaware of a use
> case for these.
>
> This requires the _ExtInt extension enabled in clang, which is under
> review.
1. Please explain the use case.
2. All patches have the same commit message which is not useful.
Please spend some time in the commit message to explain what each
individual patch does.
3. The test_extint.py is mostly a copy-and-paste from the existing
test_offload.py? Does it need most of the test_offload.py
to test the BTF 256/512 bit int? Please create a minimal
test and use the test_progs.c infra-structure.
prev parent reply other threads:[~2021-01-05 19:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 14:45 [PATCH v3 0/4] btf: support ints larger than 128 bits Sean Young
2021-01-05 14:45 ` [PATCH v3 1/4] btf: add support for " Sean Young
2021-01-06 5:10 ` Andrii Nakryiko
2021-01-06 5:16 ` Andrii Nakryiko
2021-01-05 14:45 ` [PATCH v3 2/4] libbpf: " Sean Young
2021-01-05 14:45 ` [PATCH v3 3/4] bpftool: " Sean Young
2021-01-06 5:13 ` Andrii Nakryiko
2021-01-05 14:45 ` [PATCH v3 4/4] bpf: add tests " Sean Young
2021-01-06 5:26 ` Andrii Nakryiko
2021-01-05 19:51 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105195113.lr3mc5ma2rvej4r6@kafai-mbp \
--to=kafai@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=sean@mess.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).