From: Ayush Sawal <ayush.sawal@chelsio.com>
To: kuba@kernel.org, netdev@vger.kernel.org, davem@davemloft.net
Cc: secdev@chelsio.com, Ayush Sawal <ayush.sawal@chelsio.com>,
Rohit Maheshwari <rohitm@chelsio.com>
Subject: [PATCH net 2/7] chtls: Remove invalid set_tcb call
Date: Wed, 6 Jan 2021 09:59:07 +0530 [thread overview]
Message-ID: <20210106042912.23512-3-ayush.sawal@chelsio.com> (raw)
In-Reply-To: <20210106042912.23512-1-ayush.sawal@chelsio.com>
At the time of SYN_RECV, connection information is not
initialized at FW, updating tcb flag over uninitialized
connection causes adapter crash. We don't need to
update the flag during SYN_RECV state, so avoid this.
Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition")
Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com>
Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com>
---
drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c
index 561b5f2273af..431d1e3844ab 100644
--- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c
+++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c
@@ -2096,9 +2096,6 @@ static void chtls_abort_req_rss(struct sock *sk, struct sk_buff *skb)
int queue = csk->txq_idx;
if (is_neg_adv(req->status)) {
- if (sk->sk_state == TCP_SYN_RECV)
- chtls_set_tcb_tflag(sk, 0, 0);
-
kfree_skb(skb);
return;
}
--
2.28.0.rc1.6.gae46588
next prev parent reply other threads:[~2021-01-06 4:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 4:29 [PATCH net 0/7] Bug fixes for chtls driver Ayush Sawal
2021-01-06 4:29 ` [PATCH net 1/7] chtls: Fix hardware tid leak Ayush Sawal
2021-01-06 4:29 ` Ayush Sawal [this message]
2021-01-06 4:29 ` [PATCH net 3/7] chtls: Fix panic when route to peer not configured Ayush Sawal
2021-01-06 4:29 ` [PATCH net 4/7] chtls: Avoid unnecessary freeing of oreq pointer Ayush Sawal
2021-01-06 4:29 ` [PATCH net 5/7] chtls: Replace skb_dequeue with skb_peek Ayush Sawal
2021-01-06 4:29 ` [PATCH net 6/7] chtls: Added a check to avoid NULL pointer dereference Ayush Sawal
2021-01-06 4:29 ` [PATCH net 7/7] chtls: Fix chtls resources release sequence Ayush Sawal
2021-01-08 1:20 ` [PATCH net 0/7] Bug fixes for chtls driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106042912.23512-3-ayush.sawal@chelsio.com \
--to=ayush.sawal@chelsio.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rohitm@chelsio.com \
--cc=secdev@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).