netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Rohit Maheshwari <rohitm@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, secdev@chelsio.com
Subject: Re: [net] net: feature check mandating HW_CSUM is wrong
Date: Wed, 6 Jan 2021 11:17:10 -0800	[thread overview]
Message-ID: <20210106111710.34ab4eab@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210106175327.5606-1-rohitm@chelsio.com>

On Wed,  6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote:
> Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong.
> And it broke tls offload feature for the drivers, which are still
> using NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM. We should use
> NETIF_F_CSUM_MASK instead.
> 
> Fixes: ae0b04b238e2 ("net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled")
> Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com>

Please use Tariq's suggestion.

Please learn to CC appropriate reviewers.

  reply	other threads:[~2021-01-06 19:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 17:53 [net] net: feature check mandating HW_CSUM is wrong Rohit Maheshwari
2021-01-06 19:17 ` Jakub Kicinski [this message]
2021-01-12 21:17   ` rohit maheshwari
2021-01-12 23:05     ` Jakub Kicinski
2021-01-13  3:35     ` Alexander Duyck
2021-01-13 17:07       ` Tariq Toukan
2021-01-15  5:38         ` rohit maheshwari
2021-01-15 16:59           ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106111710.34ab4eab@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rohitm@chelsio.com \
    --cc=secdev@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).