From: Dan Carpenter <dan.carpenter@oracle.com>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, hulkci@huawei.com,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [v2] net: qrtr: fix null pointer dereference in qrtr_ns_remove
Date: Wed, 6 Jan 2021 14:35:24 +0300 [thread overview]
Message-ID: <20210106113524.GI2809@kadam> (raw)
In-Reply-To: <1a736322-42ce-e803-f91c-dc7595acffdd@huawei.com>
On Wed, Jan 06, 2021 at 05:46:22PM +0800, Qinglang Miao wrote:
>
>
> 在 2021/1/6 16:09, Markus Elfring 写道:
> > > > > A null-ptr-deref bug is reported by Hulk Robot like this:
> > > >
> > > > Can it be clearer to use the term “null pointer dereference” for the final commit message?
> > > This advice is too detailed for 'null-ptr-deref' is known as a general phrase
> >
> > This key word was provided already by the referenced KASAN report.
> >
> Yep, you're right. 'null-ptr-deref' is not really proper here.
> >
> > > like 'use-after-free' for kernel developer, I think.
> > I suggest to reconsider the use of abbreviations at some places.
> > >
> > > > > Fix it by making …
> > > >
> > > > Would you like to replace this wording by the tag “Fixes”?
> > > Sorry, I didn't get your words.
> > >
> > > 'Fix it by' follows the solution
> >
> > I propose to specify the desired adjustments without such a prefix
> > in the change description.
> Sorry, I can understand what you means, but I still disagree with this one,
> for:
>
> 1. 'Fix it by' is everywhere in kernel commit message.
> 2. I think adding it or not makes no change for understanding.
> 3. I'm not sure this is an official proposal.
>
Feel free to ignore Markus... :/ We have asked him over and over to
stop sending these sort of advice but he refused and eventually he was
banned from the mailing lists. The rest of us can't see his messages to
you unless we're included personally in the CC list.
regards,
dan carpenter
prev parent reply other threads:[~2021-01-06 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 5:57 [PATCH v2] net: qrtr: fix null-ptr-deref in qrtr_ns_remove Qinglang Miao
2021-01-06 0:50 ` David Miller
[not found] ` <4596fb37-5e74-5bf6-60e5-ded6fbb83969@web.de>
2021-01-06 6:06 ` [PATCH v2] net: qrtr: fix null pointer dereference " Qinglang Miao
[not found] ` <b70726b8-0965-1fb9-2af1-2e05609905ea@web.de>
2021-01-06 9:46 ` [v2] " Qinglang Miao
2021-01-06 11:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106113524.GI2809@kadam \
--to=dan.carpenter@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoqinglang@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).